From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Matthew Coleman" <matt@1eanda.com>,
"Stephon Harris" <theonestep4@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Git mailing list" <git@vger.kernel.org>
Subject: Re: [PATCH] completion: reduce overhead of clearing cached --options
Date: Tue, 17 Apr 2018 07:43:56 +0900 [thread overview]
Message-ID: <xmqqmuy2wz4j.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CANQwDwf8sBFuKBXG6Yt5CH9+E2doqB6rB-_oQ4U7vjTOYBfu_g@mail.gmail.com> ("Jakub Narębski"'s message of "Mon, 16 Apr 2018 15:29:19 +0200")
Jakub Narębski <jnareb@gmail.com> writes:
> On 16 April 2018 at 15:15, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>> No. 'sed' would only need need help when its input comes from a buggy
>> 'set' builtin of a particular version of Bash from a particular vendor.
>>
>> As far as I can test this in Travis CI's OSX builds, ZSH doesn't seem to
>> be affected, neither the version Apple ships by default nor the version
>> installed via homebrew.
>
> That's nice - this means that the patch fixes all of the issue.
> The above information should be, in my opinion, included
> in the commit message, though.
Yeah, I tend to agree. Thanks.
next prev parent reply other threads:[~2018-04-16 22:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 3:10 [PATCH] specify encoding for sed command Stephon Harris
2018-04-05 6:53 ` Ævar Arnfjörð Bjarmason
2018-04-05 9:42 ` Eric Sunshine
2018-04-05 9:43 ` SZEDER Gábor
2018-04-10 7:18 ` Matt Coleman
2018-04-11 20:42 ` Matt Coleman
2018-04-12 22:12 ` Matthew Coleman
2018-04-13 0:01 ` SZEDER Gábor
2018-04-13 3:00 ` Matthew Coleman
2018-04-13 10:30 ` [PATCH] completion: reduce overhead of clearing cached --options SZEDER Gábor
2018-04-13 21:44 ` Jakub Narebski
2018-04-13 22:23 ` SZEDER Gábor
2018-04-14 13:27 ` Jakub Narebski
2018-04-16 18:23 ` Jacob Keller
2018-04-16 20:35 ` Matthew Coleman
2018-04-16 5:10 ` Junio C Hamano
2018-04-16 13:15 ` SZEDER Gábor
2018-04-16 13:29 ` Jakub Narębski
2018-04-16 22:43 ` Junio C Hamano [this message]
2018-04-17 22:02 ` [PATCH v2] " SZEDER Gábor
2018-04-17 23:45 ` Junio C Hamano
2018-05-07 15:05 ` Matthew Coleman
2018-05-08 2:28 ` Todd Zullinger
2018-05-08 3:28 ` Junio C Hamano
2018-06-07 5:48 ` Jonathan Nieder
2018-06-07 12:07 ` Dave Borowitz
2018-06-07 12:41 ` Rick van Hattem
2018-06-08 21:16 ` SZEDER Gábor
2018-06-08 21:23 ` Jonathan Nieder
2018-06-08 21:41 ` SZEDER Gábor
2018-06-08 21:52 ` Jonathan Nieder
2018-06-08 21:58 ` SZEDER Gábor
2018-06-11 17:53 ` Junio C Hamano
2018-06-11 18:20 ` [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options) Jonathan Nieder
2018-06-12 8:46 ` SZEDER Gábor
2018-06-12 9:48 ` SZEDER Gábor
2018-06-12 9:51 ` Rick van Hattem
2018-04-08 23:17 ` [PATCH] specify encoding for sed command Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmuy2wz4j.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=matt@1eanda.com \
--cc=pclouds@gmail.com \
--cc=szeder.dev@gmail.com \
--cc=theonestep4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).