git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] doc: git-describe
@ 2018-08-14 12:58 William Pursell
  2018-08-14 16:14 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: William Pursell @ 2018-08-14 12:58 UTC (permalink / raw)
  To: git

commit cc4bd5268b2dbe90279198acb400a528ee23f5d5
Author: William Pursell <williamp@wepay.com>
Date:   Tue Aug 14 06:41:00 2018 -0600

    doc: Reference <mark> for --dirty/--broken

diff --git a/Documentation/git-describe.txt b/Documentation/git-describe.txt
index e027fb8c4b..f7d67306c0 100644
--- a/Documentation/git-describe.txt
+++ b/Documentation/git-describe.txt
@@ -39,11 +39,12 @@ OPTIONS
 --broken[=<mark>]::
  Describe the state of the working tree.  When the working
  tree matches HEAD, the output is the same as "git describe
- HEAD".  If the working tree has local modification "-dirty"
- is appended to it.  If a repository is corrupt and Git
- cannot determine if there is local modification, Git will
- error out, unless `--broken' is given, which appends
- the suffix "-broken" instead.
+ HEAD".  If the working tree has local modification, "-dirty"
+ (or <mark>, if supplied) is appended to it.  If a repository
+ is corrupt and Git cannot determine if there is local
+ modification, Git will error out unless `--broken' is given
+ in which case it will append the suffix "-broken" (or <mark>,
+ if supplied) instead.

 --all::
  Instead of using only the annotated tags, use any ref

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: git-describe
  2018-08-14 12:58 [PATCH] doc: git-describe William Pursell
@ 2018-08-14 16:14 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-08-14 16:14 UTC (permalink / raw)
  To: William Pursell; +Cc: git

William Pursell <william.r.pursell@gmail.com> writes:

> commit cc4bd5268b2dbe90279198acb400a528ee23f5d5
> Author: William Pursell <williamp@wepay.com>
> Date:   Tue Aug 14 06:41:00 2018 -0600
>
>     doc: Reference <mark> for --dirty/--broken
>

Thanks for trying to help.  Overall the resulting text does look
much better than the original, but

 - "git show" output is for your own consumption, it is not
   something you would feed other people (see patches from other
   people on the list,
   https://public-inbox.org/git/20180814110525.17801-7-ao2@ao2.it/raw
   for example)

 - Please sign-off your patch (see Documentation/SubmittingPatches)

 - The patch is seriously whitespace damaged and does not apply.
   Please first try sending it to yourself and make sure it applies
   to the commit your change was based on, before sending it to the
   list.

Thanks.

> diff --git a/Documentation/git-describe.txt b/Documentation/git-describe.txt
> index e027fb8c4b..f7d67306c0 100644
> --- a/Documentation/git-describe.txt
> +++ b/Documentation/git-describe.txt
> @@ -39,11 +39,12 @@ OPTIONS
>  --broken[=<mark>]::
>   Describe the state of the working tree.  When the working
>   tree matches HEAD, the output is the same as "git describe
> - HEAD".  If the working tree has local modification "-dirty"
> - is appended to it.  If a repository is corrupt and Git
> - cannot determine if there is local modification, Git will
> - error out, unless `--broken' is given, which appends
> - the suffix "-broken" instead.
> + HEAD".  If the working tree has local modification, "-dirty"
> + (or <mark>, if supplied) is appended to it.  If a repository
> + is corrupt and Git cannot determine if there is local
> + modification, Git will error out unless `--broken' is given
> + in which case it will append the suffix "-broken" (or <mark>,
> + if supplied) instead.
>
>  --all::
>   Instead of using only the annotated tags, use any ref

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-14 16:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 12:58 [PATCH] doc: git-describe William Pursell
2018-08-14 16:14 ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).