From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Thomas Gummerer <t.gummerer@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
lucas.de.marchi@gmail.com
Subject: Re: [PATCH] range-diff: allow to diff files regardless submodule
Date: Thu, 11 Oct 2018 17:25:02 +0900 [thread overview]
Message-ID: <xmqqmurkgaap.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87in29dj55.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 11 Oct 2018 09:42:14 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Wed, Oct 10 2018, Lucas De Marchi wrote:
>
>> Do like it's done in grep so mode doesn't end up as
>> 0160000, which means range-diff doesn't work if one has
>> "submodule.diff = log" in the configuration. Without this
>> while using range-diff I only get a
>>
>> Submodule a 0000000...0000000 (new submodule)
>
> I'm not familiar enough with this to tell what the real problem is
> that's being solved from the commit message, but if it means that now
> range-diff works in some configuration, presumably that can be reduced
> to a simple set of commands that didn't work before but now does, and
> therefore a test in t/t3206-range-diff.sh.
Yes, I agree on both counts (i.e. it was totally unclear what
problem is being solved and what the root cause of the problem is,
and we would want a new test to protect this "fix" from getting
broken in the future.
Thanks.
next prev parent reply other threads:[~2018-10-11 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 15:09 [PATCH] range-diff: allow to diff files regardless submodule Lucas De Marchi
2018-10-11 0:02 ` brian m. carlson
2018-10-11 7:50 ` Lucas De Marchi
2018-10-12 9:24 ` Johannes Schindelin
2018-10-12 23:17 ` brian m. carlson
2018-10-11 7:42 ` Ævar Arnfjörð Bjarmason
2018-10-11 8:14 ` Lucas De Marchi
2018-10-11 8:17 ` [PATCH v2] " Lucas De Marchi
2018-10-12 9:26 ` Johannes Schindelin
2018-10-11 8:25 ` Junio C Hamano [this message]
2018-10-23 14:07 ` [PATCH] " Lucas De Marchi
2018-10-24 2:12 ` Junio C Hamano
2018-10-24 2:43 ` Lucas De Marchi
2018-10-24 5:12 ` Junio C Hamano
2018-10-24 5:18 ` Junio C Hamano
2018-10-24 17:19 ` Lucas De Marchi
2018-10-24 19:46 ` [PATCH v3] range-diff: allow to diff files regardless of submodule config Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmurkgaap.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).