From: Junio C Hamano <gitster@pobox.com>
To: Stefan Xenos <sxenos@google.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v5 1/8] technical doc: add a design doc for the evolve command
Date: Fri, 15 Feb 2019 15:36:15 -0800 [thread overview]
Message-ID: <xmqqmumw4ob4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPL8ZiseLQgemzr-U2yFM815Ty+Di_cGznZ_hNAcf3sMy5mXEg@mail.gmail.com> (Stefan Xenos's message of "Fri, 15 Feb 2019 14:18:49 -0800")
Stefan Xenos <sxenos@google.com> writes:
>> saw a few comments that say "needs further work".
>
> Could you clarify where you saw those comments? Were they something I
> wrote ...
Yeah, e.g.
/* TODO: This causes a crash. It sets one of the atom_value handlers to
* something invalid, which causes a crash later when we all
* show_ref_array_item. Figure out why this happens and put back the sorting.
*ref_array_sort(sorting, &array); */
was what caught my attention in the previous and this version. As I
said, it is OK if the code is not completely finished. It's an
iterative process.
By the way, our multi-line comments have opening /* and closing */
on their own lines.
Thanks.
prev parent reply other threads:[~2019-02-15 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 4:30 [PATCH v5 1/8] technical doc: add a design doc for the evolve command sxenos
2019-02-15 4:30 ` [PATCH v5 2/8] sha1-array: implement oid_array_readonly_contains sxenos
2019-02-15 4:31 ` [PATCH v5 3/8] ref-filter: add the metas namespace to ref-filter sxenos
2019-02-15 4:31 ` [PATCH v5 4/8] evolve: add support for parsing metacommits sxenos
2019-02-15 4:31 ` [PATCH v5 5/8] evolve: add the change-table structure sxenos
2019-02-15 4:31 ` [PATCH v5 6/8] evolve: add support for writing metacommits sxenos
2019-02-15 4:31 ` [PATCH v5 7/8] evolve: implement the git change command sxenos
2019-02-15 4:31 ` [PATCH v5 8/8] evolve: add the git change list command sxenos
2019-02-15 18:23 ` [PATCH v5 1/8] technical doc: add a design doc for the evolve command Junio C Hamano
2019-02-15 22:18 ` Stefan Xenos
2019-02-15 23:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmumw4ob4.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sxenos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).