From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] builtin/log: downcase the beginning of error messages
Date: Fri, 22 Feb 2019 12:40:38 -0800 [thread overview]
Message-ID: <xmqqmumnpneh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRhk-0LBCmUQ4LszJrnmnXCDz7HxWqDnKX53woBYhr-KQ@mail.gmail.com> (Eric Sunshine's message of "Fri, 22 Feb 2019 15:24:15 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> - die(_("Failed to get upstream, if you want to record base commit automatically,\n"
>> + die(_("failed to get upstream, if you want to record base commit automatically,\n"
>> "please use git branch --set-upstream-to to track a remote branch.\n"
>> "Or you could specify base commit by --base=<base-commit-id> manually."));
>
> The capitalized "Or you..." is odd after s/Failed/failed/.
It briefly bothered me, too, but after realizing that this is not
the whole sentence, it no longer looks so bad to me. The thing is
that "Failed" (or "failed") is *not* what starts the message. This
one is die(), so what you'd actually see is
fatal: failed to get upstream, ... to track a remote branch.
Or you could ...
with "fatal:" prefix.
next prev parent reply other threads:[~2019-02-22 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:11 [PATCH 0/3] format-patch --no-clobber Junio C Hamano
2019-02-22 20:11 ` [PATCH 1/3] builtin/log: downcase the beginning of error messages Junio C Hamano
2019-02-22 20:24 ` Eric Sunshine
2019-02-22 20:40 ` Junio C Hamano [this message]
2019-02-22 20:11 ` [PATCH 2/3] format-patch: notice failure to open cover letter for writing Junio C Hamano
2019-02-22 20:11 ` [PATCH 3/3] format-patch: --no-clobber refrains from overwriting output files Junio C Hamano
2019-02-22 20:38 ` Eric Sunshine
2019-02-23 13:34 ` Jeff King
2019-03-12 20:53 ` Ntentos Stavros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmumnpneh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).