From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: Rohit Ashiwal <rohit.ashiwal265@gmail.com>,
git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: What's cooking in git.git (Mar 2019, #04; Wed, 20)
Date: Thu, 21 Mar 2019 09:31:36 +0900 [thread overview]
Message-ID: <xmqqmulpukyf.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190320225638.GF32487@hank.intra.tgummerer.com> (Thomas Gummerer's message of "Wed, 20 Mar 2019 22:56:38 +0000")
Thomas Gummerer <t.gummerer@gmail.com> writes:
> On 03/21, Rohit Ashiwal wrote:
>> Hey Junio!
>>
>> On Wed, 20 Mar 2019 12:13:47 +0900 Junio C Hamano <gitster@pobox.com> wrote:
>> > * ra/t3600-test-path-funcs (2019-03-08) 3 commits
>> > - t3600: use helpers to replace test -d/f/e/s <path>
>> > - t3600: modernize style
>> > - test functions: add function `test_file_not_empty`
>> >
>> > A GSoC micro.
>> >
>> > Will merge to 'next'.
>> > cf. <20190304120801.28763-1-rohit.ashiwal265@gmail.com> (v3)
>>
>> If we are going to merge these in next revision, I say there are some
>> minor changes that Eric suggested, basically there were some extra spaces
>> in commit messages and a small change in commit message of [PATCH v3 3/3].
>> There will *not* be any change in code. Should I attend to them or we are
>> merging anyway?
>
> Junio sometimes applies these fixes himself, if he deems it easier to
> apply them directly than to wait for another iteration, and if he has
> time to do so. If you have a look at the ra/t3600-test-path-funcs
> branch in gitster/git, e.g. on GitHub [*1*], you can see that Eric's
> suggestions for the commit message in 3/3 have already been applied,
> so there's nothing more you need to do here at this point.
Thanks.
next prev parent reply other threads:[~2019-03-21 0:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 3:13 What's cooking in git.git (Mar 2019, #04; Wed, 20) Junio C Hamano
2019-03-20 4:56 ` Junio C Hamano
2019-03-20 11:23 ` Thomas Gummerer
2019-03-20 22:05 ` Rohit Ashiwal
2019-03-20 22:56 ` Thomas Gummerer
2019-03-20 23:07 ` Rohit Ashiwal
2019-03-21 0:31 ` Junio C Hamano [this message]
2019-03-20 22:42 ` Ævar Arnfjörð Bjarmason
2019-03-21 0:46 ` Junio C Hamano
2019-03-21 5:19 ` Junio C Hamano
2019-03-21 9:13 ` Ævar Arnfjörð Bjarmason
2019-03-21 9:46 ` Junio C Hamano
2019-03-21 10:37 ` Ævar Arnfjörð Bjarmason
2019-03-21 11:14 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmulpukyf.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rohit.ashiwal265@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).