From: Junio C Hamano <gitster@pobox.com> To: Rohit Ashiwal <rohit.ashiwal265@gmail.com> Cc: Dscho <Johannes.Schindelin@gmx.de>, Git Mailing List <git@vger.kernel.org>, Martin <martin.agren@gmail.com>, Thomas <t.gummerer@gmail.com>, Elijah <newren@gmail.com>, Phillip <phillip.wood123@gmail.com> Subject: Re: [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag Date: Tue, 23 Jul 2019 13:57:08 -0700 Message-ID: <xmqqmuh4sc4b.fsf@gitster-ct.c.googlers.com> (raw) In-Reply-To: <20190723195932.16951-1-rohit.ashiwal265@gmail.com> (Rohit Ashiwal's message of "Wed, 24 Jul 2019 01:29:32 +0530") Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes: > Hi Junio > > On Fri, 19 Jul 2019 14:33:49 -0700 Junio C Hamano <gitster@pobox.com> wrote: >> >> > t/t3431-rebase-options-compatibility.sh | 66 +++++++++++++++++++++++++ >> >> Isn't 3431 already taken? > > It is not in git/git[1]. That's a very selfish attitude ;-) Pay attention to what others are doing while you are working on this topic (hint: do not limit your check to 'master', but make sure your changes also work well when merged to 'next' and 'pu'---make a trial merge or two and run test suite, for example). >> > + git checkout --orphan master && >> > + q_to_tab >file <<-EOF && >> > + line 1 >> > + line 2 >> > + line 3 >> > + EOF >> >> This will trigger "indent-with-space". Instead of using q-to-tab, >> perhaps something like this would be more appropriate (not limited >> to this piece, but also other ones in this script that actually do >> use Q to visualize a tab)? >> >> sed -e "s/^|//" >file <<-EOF && >> |line 1 >> | line 2 >> |line 3 >> EOF >> > > Oh! My mistake, I should have used cat instead. I am not sure how you would avoid indent-with-space with "cat". With the use of "sed" like I showed above to spell the left margin explicitly out, we can---I am not saying it's the only way, but I do not think of a clean way to do the same with "cat".
next prev parent reply other threads:[~2019-07-23 20:57 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 18:50 [GSoC][PATCH 0/1] rebase -i: support --ignore-whitespace Rohit Ashiwal 2019-07-12 18:50 ` [GSoC][PATCH 1/1] rebase -i: add --ignore-whitespace flag Rohit Ashiwal 2019-07-15 17:57 ` Junio C Hamano 2019-07-15 22:00 ` Rohit Ashiwal 2019-07-15 22:08 ` Junio C Hamano 2019-07-15 22:42 ` Rohit Ashiwal 2019-07-12 18:53 ` [GSoC][PATCH 0/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 " Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 1/2] sequencer: add NULL checks under read_author_script Rohit Ashiwal 2019-07-18 19:03 ` [GSoC][PATCH v2 2/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-19 22:36 ` Junio C Hamano 2019-08-02 20:57 ` Rohit Ashiwal 2019-07-20 14:56 ` Phillip Wood 2019-07-23 19:57 ` Rohit Ashiwal 2019-07-24 13:33 ` Phillip Wood 2019-07-19 21:26 ` [GSoC][PATCH v2 0/2] " Junio C Hamano 2019-07-19 21:47 ` Junio C Hamano 2019-07-12 18:53 ` [GSoC][PATCH 1/2] sequencer: add NULL checks under read_author_script Rohit Ashiwal 2019-07-15 18:04 ` Junio C Hamano 2019-07-12 18:53 ` [GSoC][PATCH 2/2] rebase -i: support --committer-date-is-author-date Rohit Ashiwal 2019-07-14 11:31 ` Rohit Ashiwal 2019-07-18 18:55 ` [GSoC][PATCH v2 0/1] rebase -i: support --ignore-whitespace Rohit Ashiwal 2019-07-18 18:55 ` [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag Rohit Ashiwal 2019-07-19 21:33 ` Junio C Hamano 2019-07-23 19:59 ` Rohit Ashiwal 2019-07-23 20:57 ` Junio C Hamano [this message] 2019-07-22 10:00 ` Phillip Wood 2019-07-23 19:58 ` Rohit Ashiwal 2019-07-23 21:01 ` Elijah Newren 2019-07-24 11:14 ` Johannes Schindelin 2019-07-24 21:18 ` [GSoC][PATCH v3 0/1] " Rohit Ashiwal 2019-07-24 21:18 ` [GSoC][PATCH v3 1/1] " Rohit Ashiwal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqmuh4sc4b.fsf@gitster-ct.c.googlers.com \ --to=gitster@pobox.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=martin.agren@gmail.com \ --cc=newren@gmail.com \ --cc=phillip.wood123@gmail.com \ --cc=rohit.ashiwal265@gmail.com \ --cc=t.gummerer@gmail.com \ --subject='Re: [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git