git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Drew DeVault <sir@cmpwn.com>,
	git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH 2/2] send-pack: downgrade push options error to warning
Date: Tue, 18 Feb 2020 09:44:46 -0800	[thread overview]
Message-ID: <xmqqmu9fkcxd.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200218054009.GD1641086@coredump.intra.peff.net> (Jeff King's message of "Tue, 18 Feb 2020 00:40:09 -0500")

Jeff King <peff@peff.net> writes:

> This makes me a little nervous, because we don't know what those push
> options were supposed to do.

Thanks for stopping this early.  As you said, this die() is very
much deliberate way for us to make sure that we do not damage an
receiving end that is not prepared.
          
> So perhaps it would make sense to do one or both of:
>
>  - allow remote.*.pushOptions for specific remotes
>
>  - add a push.pushOptionIfAble key which behaves similarly to
>    push.pushOption, but is quietly ignored if options aren't supported.
>    Then you could put options there that you know are safe to be
>    ignored.

Sensible suggestions.

  reply	other threads:[~2020-02-18 17:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 14:44 [PATCH 1/2] git-receive-pack: document push options Drew DeVault
2020-02-17 14:44 ` [PATCH 2/2] send-pack: downgrade push options error to warning Drew DeVault
2020-02-18  5:40   ` Jeff King
2020-02-18 17:44     ` Junio C Hamano [this message]
2020-02-18  5:30 ` [PATCH 1/2] git-receive-pack: document push options Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmu9fkcxd.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sir@cmpwn.com \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).