git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: benno@bmevers.de
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH v2] describe: dont abort too early when searching tags
Date: Wed, 26 Feb 2020 12:13:31 -0800	[thread overview]
Message-ID: <xmqqmu95hztg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200226174853.27404-1-benno@bmevers.de> (benno@bmevers.de's message of "Wed, 26 Feb 2020 18:48:53 +0100")

benno@bmevers.de writes:

> Thus, this commit modifies the stopping condition to only abort
> the search when only one branch is left to search *and* all current
> best candidates are descendants from that branch.
>
> For repositories with a single root, this condition is always
> true: When the search is reduced to a single active branch, the
> current commit must be an ancestor of *all* tag candidates. This
> means that in the common case, this change will have no negative
> performance impact since the same number of commits as before will
> be traversed.
>
> Signed-off-by: Benno Evers <benno@bmevers.de>
> ---
> Changes since v1:
>
>   * Added a paragraph that discusses performance impact to the commit
>     message.
> ...
> +'
> +
> +test_done
> \ No newline at end of file

I'll fix this while queuing.

Thanks for an update.

      reply	other threads:[~2020-02-26 20:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 17:48 [PATCH v2] describe: dont abort too early when searching tags benno
2020-02-26 20:13 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmu95hztg.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=benno@bmevers.de \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).