git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, me@ttaylorr.com, jrnieder@gmail.com,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v2] config: set pack.useSparse=true by default
Date: Fri, 20 Mar 2020 13:43:52 -0700	[thread overview]
Message-ID: <xmqqmu8abvuf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.585.v2.git.1584707247753.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Fri, 20 Mar 2020 12:27:27 +0000")

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

>     Here is a small patch to convert pack.useSparse to true by default. It's
>     been released for over a year, so the feature is quite stable.

I would not say anything more than "its' been released for over a
year, so the feature is known not to cause problems when it is not
enabled (in other words, we coded our if/else correctly)", unless
some telemetry tells us that significant number of users with widely
differing use patterns have enabled it and are not seeing much
negative effect.  And we can tell if it is stable only if we flip
the default.

> I'm submitting this now to allow it to cook for a while during the
> next release cycle.

I agree that it is about time to see if flipping of default would be
a good move for users whose usage patterns are unlike VFS for Git by
cooking a change like this in 'next', definitely at least a cycle
but possible a bit more, and it is a good idea to have it at the
beginning of the next cycle.  Very much appreciated.

Thanks.

  parent reply	other threads:[~2020-03-20 20:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  1:58 [PATCH] config: set pack.useSparse=true by default Derrick Stolee via GitGitGadget
2020-03-19 23:13 ` Jonathan Nieder
2020-03-20  0:34   ` Derrick Stolee
2020-03-20 12:27 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2020-03-20 12:38   ` [PATCH v3 0/2] " Derrick Stolee via GitGitGadget
2020-03-20 12:38     ` [PATCH v3 1/2] " Derrick Stolee via GitGitGadget
2020-03-20 12:38     ` [PATCH v3 2/2] pack-objects: flip the use of GIT_TEST_PACK_SPARSE Derrick Stolee via GitGitGadget
2020-03-20 20:43   ` Junio C Hamano [this message]
2020-03-20 21:14     ` [PATCH v2] config: set pack.useSparse=true by default Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmu8abvuf.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).