git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] githooks.txt: use correct "reference-transaction" hook name
@ 2020-07-24 13:57 starlord via GitGitGadget
  2020-07-24 14:21 ` Patrick Steinhardt
  0 siblings, 1 reply; 3+ messages in thread
From: starlord via GitGitGadget @ 2020-07-24 13:57 UTC (permalink / raw)
  To: git; +Cc: Patrick Steinhardt, Jiang Xin, starlord, Bojun Chen

From: Bojun Chen <bojun.cbj@alibaba-inc.com>

The "reference transaction" hook was introduced in commit 6754159767
(refs: implement reference transaction hook, 2020-06-19). The name of
the hook is declared as "reference-transaction" in "refs.c" and
testcases, but the name declared in "githooks.txt" is different.

Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>
---
    githooks.txt: use correct "reference-transaction" hook name

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/681

 Documentation/githooks.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index 642471109f..31b601e4bc 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt
@@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
 `git send-pack` on the other end, so you can simply `echo` messages
 for the user.
 
-ref-transaction
-~~~~~~~~~~~~~~~
+reference-transaction
+~~~~~~~~~~~~~~~~~~~~~
 
 This hook is invoked by any Git command that performs reference
 updates. It executes whenever a reference transaction is prepared,

base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name
  2020-07-24 13:57 [PATCH] githooks.txt: use correct "reference-transaction" hook name starlord via GitGitGadget
@ 2020-07-24 14:21 ` Patrick Steinhardt
  2020-07-24 20:54   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Patrick Steinhardt @ 2020-07-24 14:21 UTC (permalink / raw)
  To: starlord via GitGitGadget; +Cc: git, Jiang Xin, starlord, Bojun Chen

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Hi Bojun,

On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
> From: Bojun Chen <bojun.cbj@alibaba-inc.com>
> 
> The "reference transaction" hook was introduced in commit 6754159767
> (refs: implement reference transaction hook, 2020-06-19). The name of
> the hook is declared as "reference-transaction" in "refs.c" and
> testcases, but the name declared in "githooks.txt" is different.
> 
> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>

Indeed, thanks for catching this!

Reviewed-by: Patrick Steinhardt <ps@pks.im>

Patrick

> ---
>     githooks.txt: use correct "reference-transaction" hook name
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/681
> 
>  Documentation/githooks.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index 642471109f..31b601e4bc 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
>  `git send-pack` on the other end, so you can simply `echo` messages
>  for the user.
>  
> -ref-transaction
> -~~~~~~~~~~~~~~~
> +reference-transaction
> +~~~~~~~~~~~~~~~~~~~~~
>  
>  This hook is invoked by any Git command that performs reference
>  updates. It executes whenever a reference transaction is prepared,
> 
> base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda
> -- 
> gitgitgadget

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name
  2020-07-24 14:21 ` Patrick Steinhardt
@ 2020-07-24 20:54   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2020-07-24 20:54 UTC (permalink / raw)
  To: Patrick Steinhardt
  Cc: starlord via GitGitGadget, git, Jiang Xin, starlord, Bojun Chen

Patrick Steinhardt <ps@pks.im> writes:

> Hi Bojun,
>
> On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
>> From: Bojun Chen <bojun.cbj@alibaba-inc.com>
>> 
>> The "reference transaction" hook was introduced in commit 6754159767
>> (refs: implement reference transaction hook, 2020-06-19). The name of
>> the hook is declared as "reference-transaction" in "refs.c" and
>> testcases, but the name declared in "githooks.txt" is different.
>> 
>> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>
>
> Indeed, thanks for catching this!
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-24 20:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 13:57 [PATCH] githooks.txt: use correct "reference-transaction" hook name starlord via GitGitGadget
2020-07-24 14:21 ` Patrick Steinhardt
2020-07-24 20:54   ` Junio C Hamano

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git