From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 354951F9FC for ; Sun, 21 Mar 2021 22:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbhCUWRi (ORCPT ); Sun, 21 Mar 2021 18:17:38 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:63271 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbhCUWRG (ORCPT ); Sun, 21 Mar 2021 18:17:06 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0EAD2C5A8D; Sun, 21 Mar 2021 18:17:06 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=4FPRVRquwIXwaJkwFVtMSm5func=; b=cxQHiZ h4vi09ejrXv6goL3S4k5vt/1yeA/oqanP5HunRoNEjMVaqx0VgCRdX8wnr/0c0zu YzFcDDgULhiEqMI6EyZTC5Ojtw6XroXuApdXYP8164Ox5dkqJn8a0W48IVsfAfV0 /lWgzpmQuWw4ehOF9snyUdjkJ+EeFOE432SDs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=lIzNeBAh6xhZnEs6EMZo7zhn3NlV7pCN rSx4DAUsW6pDSvqKAFTaV9ewhasWMgZLltiKs3UoFJ30CjDvGhDHBmoy3iTwidM2 xV+mBFpHaAYHGkbmda1MXzMn1CBqwhh1vBxyhRaQ9Rsv8j+2bl19vcu1F+PG4+Bk 7oJSIbjF4SQ= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id F23F7C5A8C; Sun, 21 Mar 2021 18:17:05 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 4F5A4C5A8B; Sun, 21 Mar 2021 18:17:05 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Georgios Kontaxis" Cc: "Georgios Kontaxis via GitGitGadget" , git@vger.kernel.org, =?utf-8?Q?=C3=86var_Arnfj=C3=B6r=C3=B0_Bjarmason?= , "brian m. carlson" Subject: Re: [PATCH v3] gitweb: redacted e-mail addresses feature. References: Date: Sun, 21 Mar 2021 15:17:04 -0700 In-Reply-To: (Georgios Kontaxis's message of "Sun, 21 Mar 2021 20:07:22 -0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2B22BDA8-8A93-11EB-A12F-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Georgios Kontaxis" writes: >> ... so I doubt >> the wisdom of munging the patch part at all. >> >> I may be sympathetic to the cause of the patch, but, I do not agree >> with its execution in this iteration of the patch. >> > I see your point. > > It seems hiding e-mail addresses should be limited to the commit message, > i.e., stop at the "---" line. I doubt it makes sense to redact anything in the 'patch' view at all, actually. What kind of URL does the crawler need to formulate and what pieces of information (like commit object names or branch names) does it need to fill in the URL to get a series of patches out of gitweb? As long as it takes more effort than running "git clone" against the repository, the crawler would not have much incentive to crawl and harvest addresses from the 'patch' pages, and even in the log message part, the downsides of butchering the payload would outweigh the "privacy benefit", I would have to say. Quite honestly, if a site claims to offer a 'patch' download UI but returns corrupt data back, I would say it is much worse than not offering the service at all. Perhaps disabling the 'patch' feature in repositories that enable 'privacy' feature may be a much better approach.