git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	Taylor Blau <me@ttaylorr.com>, git <git@vger.kernel.org>,
	Matthias Buehlmann <Matthias.Buehlmann@mabulous.com>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: Bug Report: Multi-line trailers containing empty lines break parsing
Date: Thu, 25 Mar 2021 11:16:08 -0700	[thread overview]
Message-ID: <xmqqmturw13r.fsf@gitster.g> (raw)
In-Reply-To: <CAOLTT8TFTcw9fkfPk-vi3REtZqCWYS28LEP5jfy-TmYuWf747g@mail.gmail.com> (ZheNing Hu's message of "Thu, 25 Mar 2021 17:33:23 +0800")

ZheNing Hu <adlternative@gmail.com> writes:

> Christian Couder <christian.couder@gmail.com> 于2021年3月25日周四 下午3:54写道:
>>
>> Maybe it's not enough, but the doc already has the following:
>>
>> ------
>> Existing trailers are extracted from the input message by looking for
>> a group of one or more lines that (i) is all trailers, or (ii) contains at
>> least one Git-generated or user-configured trailer and consists of at
>> least 25% trailers.
>> The group must be preceded by one or more empty (or whitespace-only) lines.
>> The group must either be at the end of the message or be the last
>> non-whitespace lines before a line that starts with '---' (followed by a
>> space or the end of the line). Such three minus signs start the patch
>> part of the message. See also `--no-divider` below.
>>
>> When reading trailers, there can be whitespaces after the
>> token, the separator and the value. There can also be whitespaces
>> inside the token and the value. The value may be split over multiple lines with
>> each subsequent line starting with whitespace, like the "folding" in RFC 822.
>> ------
>
>
> Maybe I don't have enough right to speak on this issue, but I always think that
>  the empty line is intentional by the designer, especially when I test it.

People like you, who is relatively new to the system and the list,
are valuable source of information for us to learn where in the
current system and documentation we have room to improve and
clarify.  You do have right, and we welcome your input.

Care to clarify what you mean by "the empty line is intentional by
the designer"?  The designer of the current "trailer" intended to
make the "last paragraph" (where "paragraph" is defined as a run of
lines without an empty line in it, so that one or more continguous
empty lines separate "paragraphs") where the trailers sit in the log
message.  Is that what you mean?  Or something else?

  reply	other threads:[~2021-03-25 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 21:54 Bug Report: Multi-line trailers containing empty lines break parsing Matthias Buehlmann
2021-02-16  2:29 ` Junio C Hamano
2021-02-16 18:07   ` Taylor Blau
2021-02-16 19:39     ` Junio C Hamano
2021-02-16 19:47       ` Taylor Blau
2021-03-23 15:17         ` Christian Couder
2021-03-23 17:39           ` Junio C Hamano
2021-03-25  7:53             ` Christian Couder
2021-03-25  9:33               ` ZheNing Hu
2021-03-25 18:16                 ` Junio C Hamano [this message]
2021-03-26 10:25                   ` ZheNing Hu
2021-03-25 18:08               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmturw13r.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Matthias.Buehlmann@mabulous.com \
    --cc=adlternative@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).