From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Luke Shumaker <lukeshu@lukeshu.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] subtree: fix the GIT_EXEC_PATH sanity check to work on Windows
Date: Tue, 15 Jun 2021 11:37:57 +0900 [thread overview]
Message-ID: <xmqqmtrryhru.fsf@gitster.g> (raw)
In-Reply-To: <5f2d9434b4ebb66131ea2fb9fbb62d6338af1294.1623674513.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Mon, 14 Jun 2021 12:41:52 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> Sadly, this construct is non-portable, according to
> https://pubs.opengroup.org/onlinepubs/009695399/utilities/test.html.
> However, it does not matter in practice because we still first look
> whether `$GIT_EXEC_PREFIX` is string-identical to the first component of
> `$PATH`. This will give us the expected result everywhere but in Git for
> Windows, and Git for Windows' own Bash _does_ handle the `-ef` operator.
OK. That's somewhat subtle and possibly brittle, but let's see how
it goes.
Will queue.
Thanks.
next prev parent reply other threads:[~2021-06-15 2:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 9:13 [PATCH 0/2] Fix git subtree on Windows Johannes Schindelin via GitGitGadget
2021-06-10 9:13 ` [PATCH 1/2] subtree: fix the GIT_EXEC_PATH sanity check to work " Johannes Schindelin via GitGitGadget
2021-06-11 0:40 ` Luke Shumaker
2021-06-11 1:37 ` Junio C Hamano
2021-06-11 4:31 ` Luke Shumaker
2021-06-11 10:19 ` Johannes Schindelin
2021-06-11 13:41 ` Luke Shumaker
2021-06-14 11:56 ` Johannes Schindelin
2021-06-15 2:33 ` Junio C Hamano
2021-06-15 10:56 ` Jeff King
2021-06-15 11:05 ` Bagas Sanjaya
2021-06-15 11:18 ` Jeff King
2021-06-15 11:27 ` Johannes Schindelin
2021-06-16 0:52 ` Junio C Hamano
2021-06-16 7:49 ` Jeff King
2021-06-10 9:13 ` [PATCH 2/2] subtree: fix assumption about the directory separator Johannes Schindelin via GitGitGadget
2021-06-11 1:02 ` Luke Shumaker
2021-06-11 10:35 ` Johannes Schindelin
2021-06-11 0:58 ` [PATCH 0/2] Fix git subtree on Windows Luke Shumaker
2021-06-11 10:30 ` Johannes Schindelin
2021-06-11 13:46 ` Luke Shumaker
2021-06-11 15:50 ` Felipe Contreras
2021-06-12 2:58 ` Luke Shumaker
2021-06-14 12:41 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2021-06-14 12:41 ` [PATCH v2 1/2] subtree: fix the GIT_EXEC_PATH sanity check to work " Johannes Schindelin via GitGitGadget
2021-06-15 2:37 ` Junio C Hamano [this message]
2021-06-14 12:41 ` [PATCH v2 2/2] subtree: fix assumption about the directory separator Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtrryhru.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=lukeshu@lukeshu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).