From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BD8D01F8C8 for ; Fri, 8 Oct 2021 17:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234190AbhJHRNM (ORCPT ); Fri, 8 Oct 2021 13:13:12 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:51937 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhJHRNL (ORCPT ); Fri, 8 Oct 2021 13:13:11 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 9F3F714ADFE; Fri, 8 Oct 2021 13:11:15 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=+ApU0MSa0DGFSysMd7yHEV8CAlbb7/JVxUOil/ WrCt4=; b=IXk5BlLI7qundpy2cFWVCtc/0SZmi1sgSMyCVrqL7/1UxCGvg6XIQ0 pIArZm0X8HWXwofTa3oYSOU6WDa/j8Tn0kVXqBMwXiCMzUlDE1k99fge/XdkC/rx rdoI7EROEg3LUTudnXQx0wZpCMqxVnQwhj4R4h+GWB5NFKfUjZwag= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 96A0214ADFC; Fri, 8 Oct 2021 13:11:15 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id F3AB014ADFA; Fri, 8 Oct 2021 13:11:12 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Elijah Newren Cc: Victoria Dye , Victoria Dye via GitGitGadget , Git Mailing List , Derrick Stolee , Taylor Blau , Bagas Sanjaya Subject: Re: [PATCH v2 2/7] update-index: add --force-full-index option for expand/collapse test References: <3cfa0810-4449-1170-1f7b-cd029e5ce434@github.com> Date: Fri, 08 Oct 2021 10:11:11 -0700 In-Reply-To: (Elijah Newren's message of "Thu, 7 Oct 2021 20:42:21 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: BD53042A-285A-11EC-8B29-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Elijah Newren writes: >> I see the issue of introducing a test-only option (when sparse index is >> integrated everywhere, shouldn't it be deprecated?). If there's a way to >> make this more obviously internal/temporary, I'm happy to modify it. Or, if >> semi-frequent updates of the command in the test aren't a huge issue, I can >> revert to V1. > > If it's a test-only capability you need, I'd say add it under > t/helpers/ somewhere, either a new flag for an existing subcommand of > test-tool, or a new subcommand for test-tool. Is the ability to force expanding to full index completely useless in the field? For diagnosing breakage the end-users may see in the wild, or perhaps in a specialist usecase for whatever reason working on full index is preferable and the user may want to force it once to correct an earlier mistake to enable sparse-index before toggling the configuration off, or something? If we do not foresee any such reason, I'd agree it is good to move that to t/helpers/; otherwise, I think update-index is as good as any other place, and the option will sit well next to other options like "--[no-]skip-worktree", "--[no-]assume-unchanged". It would most likely need to be used together with "--force-write-index" (or be made to imply the latter) to be useful, I suspect. Thanks.