git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <dstolee@microsoft.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] command-list.txt: remove 'sparse-index' from main help
Date: Mon, 25 Oct 2021 09:10:06 -0700	[thread overview]
Message-ID: <xmqqmtmx2iht.fsf@gitster.g> (raw)
In-Reply-To: <20211024170730.3428123-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Sun, 24 Oct 2021 19:07:30 +0200")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Ever since 'git sparse-checkout' was introduced [1] it is included in
> 'git --help' in the section "work on the current change" along with
> the commands 'add', 'mv', 'restore', and 'rm'.  It clearly doesn't
> belong to that group, moreover it can't be considered such a common
> command to belong to 'git --help' in the first place, so remove it
> from there.
>
> [1] 94c0956b60 (sparse-checkout: create builtin with 'list'
>                 subcommand, 2019-11-21)
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
>  command-list.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Redirecting to Stolee just in case for an Ack.

I tend to agree that this is a housekeeping command for a local
repository to control what are and what are not materialized in the
working tree.  It does not directly affect the history produced from
there, similar to "git gc" is, so in that sense, I do not think we
would miss it in the "list of usual commands".

If I had to have it in some category, I do agree with the current
code that it belongs to the "worktree" family, though.

Thanks, will queue.

> diff --git a/command-list.txt b/command-list.txt
> index a289f09ed6..eb9cee8dee 100644
> --- a/command-list.txt
> +++ b/command-list.txt
> @@ -168,7 +168,7 @@ git-show-index                          plumbinginterrogators
>  git-show-ref                            plumbinginterrogators
>  git-sh-i18n                             purehelpers
>  git-sh-setup                            purehelpers
> -git-sparse-checkout                     mainporcelain           worktree
> +git-sparse-checkout                     mainporcelain
>  git-stash                               mainporcelain
>  git-stage                                                               complete
>  git-status                              mainporcelain           info

      parent reply	other threads:[~2021-10-25 16:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24 17:07 [PATCH] command-list.txt: remove 'sparse-index' from main help SZEDER Gábor
2021-10-24 17:27 ` Martin Ågren
2021-10-25 15:33 ` Derrick Stolee
2021-10-25 16:10 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtmx2iht.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).