From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, fs@gigacodes.de
Subject: Re: [PATCH] RelNotes: mention known crasher when ssh signing with OpenSSH 8.7
Date: Wed, 10 Nov 2021 14:11:29 -0800 [thread overview]
Message-ID: <xmqqmtmbwtim.fsf@gitster.g> (raw)
In-Reply-To: <xmqqczn7y9kh.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 10 Nov 2021 13:39:26 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
>
>> As discussed[1] earlier, make sure there are no surprises when ssh-keygen
>> crashes on some users of OpenSSH 8.7 that are trying ssh signing.
>>
>> [1] https://lore.kernel.org/git/xmqqsfycs21q.fsf@gitster.g/
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>> ---
>> Documentation/RelNotes/2.34.0.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/RelNotes/2.34.0.txt b/Documentation/RelNotes/2.34.0.txt
>> index effab2ea4b..54dcc7240d 100644
>> --- a/Documentation/RelNotes/2.34.0.txt
>> +++ b/Documentation/RelNotes/2.34.0.txt
>> @@ -8,6 +8,9 @@ Backward compatibility notes
>>
>> * The "--preserve-merges" option of "git rebase" has been removed.
>>
>> + * The upcoming ssh signing feature is broken if used together with
>> + OpenSSH 8.7, avoid using it if you cannot update to OpenSSH 8.8
>> + (or stay at 8.6)
>
> That may be correct, but it is NOT a backward compatibility note.
So, here is what I plan to do.
diff --git c/Documentation/RelNotes/2.34.0.txt w/Documentation/RelNotes/2.34.0.txt
index effab2ea4b..6ed8b92e10 100644
--- c/Documentation/RelNotes/2.34.0.txt
+++ w/Documentation/RelNotes/2.34.0.txt
@@ -77,7 +77,10 @@ UI, Workflows & Features
* "git fsck" has been taught to report mismatch between expected and
actual types of an object better.
- * Use ssh public crypto for object and push-cert signing.
+ * In addition to GnuPG, ssh public crypto can be used for object and
+ push-cert signing. Note that this feature cannot be used with
+ ssh-keygen from OpenSSH 8.7, whose support for it is broken. Avoid
+ using it unless you update to OpenSSH 8.8.
* "git log --grep=string --author=name" learns to highlight hits just
like "git grep string" does.
next prev parent reply other threads:[~2021-11-10 22:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 0:59 [ANNOUNCE] Git v2.34.0-rc2 Junio C Hamano
2021-11-10 5:41 ` Jeff King
2021-11-10 6:00 ` Jeff King
2021-11-10 8:11 ` Carlo Arenas
2021-11-10 8:22 ` Jeff King
2021-11-10 9:15 ` Carlo Arenas
2021-11-10 9:35 ` Jeff King
2021-11-10 9:39 ` [PATCH] RelNotes: mention known crasher when ssh signing with OpenSSH 8.7 Carlo Marcelo Arenas Belón
2021-11-10 21:39 ` Junio C Hamano
2021-11-10 22:11 ` Junio C Hamano [this message]
2021-11-11 9:16 ` Jeff King
[not found] ` <YY7/peK1EOHtATEI@camp.crustytoothpaste.net>
2021-11-13 0:16 ` Junio C Hamano
2021-11-10 21:49 ` [ANNOUNCE] Git v2.34.0-rc2 Junio C Hamano
2021-11-10 6:35 ` Johannes Altmanninger
2021-11-10 8:22 ` Jeff King
2021-11-10 21:43 ` Junio C Hamano
2021-11-11 12:07 ` Jeff King
2021-11-11 17:32 ` Junio C Hamano
2021-11-11 20:23 ` Jeff King
2021-11-11 20:33 ` Junio C Hamano
2021-11-15 15:06 ` Patrick Steinhardt
2021-11-15 15:27 ` Jeff King
2021-11-15 16:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtmbwtim.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).