From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id ED4321F953 for ; Mon, 20 Dec 2021 22:12:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhLTWMk (ORCPT ); Mon, 20 Dec 2021 17:12:40 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:64990 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbhLTWMk (ORCPT ); Mon, 20 Dec 2021 17:12:40 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 160D4F03F2; Mon, 20 Dec 2021 17:12:39 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=s0e94If1KDBmMLsN5IZKFk4EiKl1jOUjYhXXva 5QS/E=; b=D5L9aB5VO8iZwT1Gcl38E9cRRtjNglFsIVvymI6gHeymLtBxSilc5v eYFzSA07lZbiCosq/cakGPfJ/6q8ciXGJCAoz8usZbMJ/qb2XF8G7FInf4uC6ep6 WzVw4r/XHcmxZ6aR4c5YHGDSOkioR8UXFHb3DDm3ycFc6LPojVdhA= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0D568F03F0; Mon, 20 Dec 2021 17:12:39 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 65B67F03ED; Mon, 20 Dec 2021 17:12:38 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Glen Choo Cc: git@vger.kernel.org, Jonathan Tan Subject: Re: [PATCH v2] builtin/fetch: skip unnecessary tasks when using --negotiate-only References: <20211207192925.67680-1-chooglen@google.com> <20211217000235.68996-1-chooglen@google.com> Date: Mon, 20 Dec 2021 14:12:37 -0800 In-Reply-To: (Glen Choo's message of "Mon, 20 Dec 2021 12:54:16 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F13B04AC-61E1-11EC-A421-CB998F0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Glen Choo writes: > But maybe I am misunderstanding how Git treats CLI options in general? > We don't ever really hide CLI options, even if they are only > internal. There is PARSE_OPT_HIDDEN, but those still show up in usage > and documentation [1]. So we actually do want users to know about these > implementation details? At least they should be told not to use from the command line when they have no business triggering whatever feature these options trigger. > Presumably, the thought process goes something like this: if we add an > option, a user *could* find a use for it (or it might accidentally > conflict with a user's flags), even if we never intended it for end user > consumption. Thus we need to treat all CLI options with care. Rather, they can keep both halves ;-)