git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jack McGuinness via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jack McGuinness <jmcguinness2@ucmerced.edu>
Subject: Re: [PATCH] area: /t/t4204-log.sh, partially modernized test script t4202
Date: Tue, 19 Apr 2022 23:13:24 -0700	[thread overview]
Message-ID: <xmqqmtggs2nv.fsf@gitster.g> (raw)
In-Reply-To: pull.1218.git.1650096550631.gitgitgadget@gmail.com

"Jack McGuinness via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Jack <jmcguinness2@ucmerced.edu>
> Subject: Re: [PATCH] area: /t/t4204-log.sh, partially modernized test script t4202

I am not sure what "area" in this context is.  Do not report what
you did in past tense on the title.

Perhaps

    Subject: [PATCH] t4202: modernize code layout

or something?

> Remove test body indentations made with spaces, replace with tabs.
> Remove blank lines at start and end of test bodies.

OK.  The title says "partially", strongly hinting that the script is
not fully modern even if we take this patch.  There should be some
mention of left-over work that is left to a later occasion here.

Thanks.

      parent reply	other threads:[~2022-04-20  6:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16  8:09 [PATCH] area: /t/t4204-log.sh, partially modernized test script t4202 Jack McGuinness via GitGitGadget
2022-04-18 12:16 ` Derrick Stolee
2022-04-20  6:13 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtggs2nv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jmcguinness2@ucmerced.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).