From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Chris Down <chris@chrisdown.name>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>,
kernel-team@fb.com
Subject: Re: [PATCH v2 1/2] bisect: output state before we are ready to compute bisection
Date: Fri, 06 May 2022 09:42:35 -0700 [thread overview]
Message-ID: <xmqqmtfuobno.fsf@gitster.g> (raw)
In-Reply-To: <YnSNWMBRZA0S8X26@nand.local> (Taylor Blau's message of "Thu, 5 May 2022 22:52:08 -0400")
Taylor Blau <me@ttaylorr.com> writes:
>> + if (!bs.nr_good && !bs.nr_bad)
>> + printf(_("status: waiting for both good and bad commits\n"));
>> + else if (bs.nr_good)
>> + printf(Q_("status: waiting for bad commit, %d good commit known\n",
>> + "status: waiting for bad commit, %d good commits known\n",
>> + bs.nr_good), bs.nr_good);
>> + else
>> + printf(_("status: waiting for good commit(s), bad commit known\n"));
>> +}
>
> Could or should these printf()'s be advise() calls instead?
Given that existing bisect_next_all() mesasge to give estimates come
to the standard output, I do not think so.
/*
* TRANSLATORS: the last %s will be replaced with "(roughly %d
* steps)" translation.
*/
printf(Q_("Bisecting: %d revision left to test after this %s\n",
"Bisecting: %d revisions left to test after this %s\n",
nr), nr, steps_msg);
I view these new messages as merely correcting the gap we used to
have. We should have been giving feedback to the end-user when they
did something, but instead we were giving feedback only when we did
something, which resulted in the original "Huh?" that motivated this
series.
I actually wonder if we should do s/status:/Bisecting:/ to make the
messages even more uniform, but if we were to go in that direction
in the longer term, we'd probably be downcasing "Bisecting" to match
our error/warning/info messages.
Thanks.
next prev parent reply other threads:[~2022-05-06 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 0:52 [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-06 0:52 ` [PATCH v2 1/2] bisect: output state before we are ready to compute bisection Chris Down
2022-05-06 2:52 ` Taylor Blau
2022-05-06 10:14 ` Chris Down
2022-05-06 16:42 ` Junio C Hamano [this message]
2022-05-06 18:12 ` Junio C Hamano
2022-05-06 0:52 ` [PATCH v2 2/2] bisect: output bisect setup status in bisect log Chris Down
2022-05-06 3:03 ` Taylor Blau
2022-05-06 10:09 ` Chris Down
2022-05-09 15:41 ` Taylor Blau
2022-05-06 16:57 ` Junio C Hamano
2022-05-06 16:47 ` Junio C Hamano
2022-05-06 18:18 ` Junio C Hamano
2022-05-09 15:43 ` Taylor Blau
2022-05-09 16:08 ` Junio C Hamano
2022-05-09 16:27 ` Taylor Blau
2022-05-07 10:58 ` [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-07 18:25 ` Junio C Hamano
2022-05-07 21:22 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtfuobno.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@chrisdown.name \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kernel-team@fb.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).