git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Diomidis Spinellis <dds@aueb.gr>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
	avarab@gmail.com
Subject: Re: [PATCH v4] grep: fix multibyte regex handling under macOS
Date: Tue, 13 Sep 2022 13:41:13 -0700	[thread overview]
Message-ID: <xmqqmtb380t2.fsf@gitster.g> (raw)
In-Reply-To: <a8ba447f-d087-1c5e-0ce0-a9040ad080d1@aueb.gr> (Diomidis Spinellis's message of "Tue, 13 Sep 2022 21:09:21 +0300")

Diomidis Spinellis <dds@aueb.gr> writes:

>> Perhaps cook this in 'next' and see if anybody screams?

Let's do this.

> I was programming in C before locale.h was introduced, so its
> availability was something that worried me as well.  I looked up
> whether we could/should use a GNU autoconf macro to test for the
> locale.h availability.  According to autoconf's documentation "All
> hosted environments that are still of interest for portable code
> provide all of the headers specified in ISO C90 (as amended in 1995):
> assert.h, [...] locale.h [...], and wctype.h. Most programs can safely
> include these headers unconditionally." [1]

Yeah, but there are folks on minor platforms where full POSIX
compliance is iffy, so whatever autoconf's documentation says
unfortunately does not weigh as much as we wish it does.



      reply	other threads:[~2022-09-13 20:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pull.1313.v2.git.git.1661289990205.gitgitgadget () gmail ! com>
2022-08-25  8:20 ` [PATCH v3] grep: fix multibyte regex handling under macOS Diomidis Spinellis
2022-08-26  0:20   ` Junio C Hamano
2022-08-26  8:58 ` [PATCH v4] " Diomidis Spinellis
2022-09-13 17:32   ` Junio C Hamano
2022-09-13 18:09     ` Diomidis Spinellis
2022-09-13 20:41       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtb380t2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=dds@aueb.gr \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).