From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B0A541F506 for ; Mon, 19 Sep 2022 18:16:58 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="AgWsjx12"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbiISSQs (ORCPT ); Mon, 19 Sep 2022 14:16:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbiISSQq (ORCPT ); Mon, 19 Sep 2022 14:16:46 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C42BF4663B for ; Mon, 19 Sep 2022 11:16:32 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id E5159140892; Mon, 19 Sep 2022 14:16:31 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=hETucSEW70LGpq3mB3dSyl5B8RpIjjWB4TM838 K8EGk=; b=AgWsjx12E38weO23EdSZRbqdr2AnoM0S2unrXT67MmlFAV3RXH2fGL EwNR7fWaa1jeZdb6/AdejVn9hekIchF6+sYq26wLxpj8e5oSc1GoLh7VivjMZz+z CCEsjF7HzEfe5tdgGuZ9eUtzv8PSlSjavYAh72sGmDRO9ftZuW3uo= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id DC132140891; Mon, 19 Sep 2022 14:16:31 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 4EE43140890; Mon, 19 Sep 2022 14:16:31 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, me@ttaylorr.com, newren@gmail.com, avarab@gmail.com, mjcheetham@outlook.com, steadmon@google.com, Glen Choo , Jonathan Tan , Teng Long Subject: Re: [PATCH v2 2/9] bundle-uri: use plain string in find_temp_filename() References: Date: Mon, 19 Sep 2022 11:16:30 -0700 In-Reply-To: (Derrick Stolee's message of "Mon, 19 Sep 2022 13:54:35 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2FC24C44-3847-11ED-A236-307A8E0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Derrick Stolee writes: > ... something deterministic based on the URI so > we can restart downloads that were halted, even if the process needs > to restart. But for now, this change helps us to remove the strbuf > from the remote_bundle_info struct. Yay for a bright future ;-) Thanks.