From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: Re: ps/receive-use-only-advertised
Date: Fri, 18 Nov 2022 15:27:18 -0800 [thread overview]
Message-ID: <xmqqmt8nkfmx.fsf@gitster.g> (raw)
In-Reply-To: <Y3PMLFuvR6hlIzbq@coredump.intra.peff.net> (Jeff King's message of "Tue, 15 Nov 2022 12:28:12 -0500")
Jeff King <peff@peff.net> writes:
>> > > "git receive-pack" used to use all the local refs as the boundary
>> > > for checking connectivity of the data "git push" sent, but now it
>> > > uses only the refs that it advertised to the pusher. In a
>> > > repository with the .hideRefs configuration, this reduces the
>> > > resource needed to perform the check, and also forces the pusher to
>> > > prove they have all objects that are necessary to complete the
>> > > history on top of only the history available to them.
>> >
>> > We have at a later point established that this is not true: the pusher
>> > does not have to prove they have all objects. As the `--not --all` part
>> > in git-rev-list(1) is merely an optimization the semantics aren't
>> > changed at all
>>
>> Thanks; this is Junio's description from when he picked up the topic
>> back in WC #08 from October. I'll need to update before graduating it
>> down.
>
> Yeah, I think you can probably just remove everything from "and also
> forces..." on.
Hmph, --not --all is a way to make the rev-list error out if the
proposed new tips are not connected with existing objects to the
"existing" refs, and I thought that removing "hidden" ones from
"--all" means that the pusher is now forced to push objects all
needed. But you are right. Excluding the hidden refs from "--all"
while doing the "rev-list new-tip --not --all" traversal does not
exclude pre-existing objects that are only reachable from these
hidden refs in the object store, so it does not help ensure that the
pusher has to prove they have these objects.
next prev parent reply other threads:[~2022-11-18 23:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 4:50 What's cooking in git.git (Nov 2022, #03; Mon, 14) Taylor Blau
2022-11-15 4:59 ` Eric Sunshine
2022-11-15 5:01 ` Taylor Blau
2022-11-15 6:28 ` ps/receive-use-only-advertised Patrick Steinhardt
2022-11-15 6:47 ` ps/receive-use-only-advertised Taylor Blau
2022-11-15 17:28 ` ps/receive-use-only-advertised Jeff King
2022-11-16 2:02 ` ps/receive-use-only-advertised Taylor Blau
2022-11-18 23:27 ` Junio C Hamano [this message]
2022-11-15 8:06 ` rp/maintenance-qol with 'make DEVELOPER=1' (was: What's cooking in git.git (Nov 2022, #03; Mon, 14)) Ævar Arnfjörð Bjarmason
2022-11-15 14:04 ` ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14) Johannes Schindelin
2022-11-16 1:20 ` Taylor Blau
2022-11-16 11:48 ` Strawbridge, Michael
2022-11-18 13:24 ` Johannes Schindelin
2022-11-15 20:58 ` Eric Sunshine
2022-11-16 2:04 ` Taylor Blau
2022-11-16 6:07 ` Elijah Newren
2022-11-16 20:16 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt8nkfmx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).