git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4 0/1] ref-filter: add new "signature" atom
Date: Thu, 26 Jan 2023 13:07:02 -0800	[thread overview]
Message-ID: <xmqqmt65atu1.fsf@gitster.g> (raw)
In-Reply-To: <20230116173814.11338-1-nsengiyumvawilberforce@gmail.com> (Nsengiyumva Wilberforce's message of "Mon, 16 Jan 2023 12:38:13 -0500")

Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com> writes:

> iv) I also moved check_commit_signature(commit, &sigc) out of the
> to avoid running GPG twice.still this change is in grab_signature()
> in ref-filter.c.

Is there some code to avoid calling check_commit_signature() or
grab_signature() itself when no %(signature) atoms is used?  When
nobody asked to use signature atom at all, calling GPG once is
already once too many.

Thanks.


  parent reply	other threads:[~2023-01-26 21:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-27  0:55 [PATCH] ref-filter: add new atom "signature" atom nsengaw4c via GitGitGadget
2022-12-27  2:20 ` Junio C Hamano
2023-01-02  4:49   ` NSENGIYUMVA WILBERFORCE
2023-01-02  8:37     ` Christian Couder
2023-01-03  0:58       ` Junio C Hamano
     [not found]   ` <CA+PPyiGd0-AiwhPa5e+fDdA9RybS+c5XeOYm5yycCZco3VHAxg@mail.gmail.com>
2023-01-08 15:21     ` NSENGIYUMVA WILBERFORCE
2022-12-27  6:11 ` Jeff King
2023-01-02  6:34   ` NSENGIYUMVA WILBERFORCE
2023-01-10  0:52 ` [PATCH v3 0/1] ref-filter: add new " Nsengiyumva Wilberforce
2023-01-10  0:52   ` [PATCH v3 1/1] " Nsengiyumva Wilberforce
2023-01-16 17:38     ` [PATCH v4 0/1] " Nsengiyumva Wilberforce
2023-01-16 17:38       ` [PATCH v4 1/1] " Nsengiyumva Wilberforce
2023-03-11 21:06         ` [PATCH v5 0/1] " Nsengiyumva Wilberforce
2023-03-11 21:06           ` [PATCH v5 1/1] " Nsengiyumva Wilberforce
2023-03-14 22:51             ` Junio C Hamano
2023-04-28 18:29             ` Kousik Sanagavarapu
2023-04-29 18:37               ` Kousik Sanagavarapu
2023-01-26 21:07       ` Junio C Hamano [this message]
2023-01-10  9:13   ` [PATCH v3 0/1] " Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmt65atu1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nsengiyumvawilberforce@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).