From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: Fwd: Should "head" also work for "HEAD" on case-insensitive FS?
Date: Thu, 27 Jul 2017 08:26:29 -0700 [thread overview]
Message-ID: <xmqqlgn9oq8q.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170727143507.bezad7dnthx4nqtc@sigill.intra.peff.net> (Jeff King's message of "Thu, 27 Jul 2017 10:35:08 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jul 26, 2017 at 05:49:47PM -0700, Junio C Hamano wrote:
>
>> What I saw was that a test have ended up with .git/%46%4F%4F when it
>> was told to create a ref "FOO" (which indicates that "FOO" was
>> passed to the files backend), which later failed to read it back
>> because the pseudo_ref handling refs.c wanted to see ".git/FOO" on
>> the reading side.
>>
>> Perhaps it is only a bug in t/t1405-main-ref-store.sh?
>
> An interesting related issue for pseudo-refs: if you encode HEAD as
> .git/%48%45%41%44, how will we recognize that directory as a git
> repository?
Yes, that is a valid point. I may have forgot to explain why the
sample change in my message upthread special cases "HEAD" and leaves
it untouched, but it is done for this exact reason.
> 1. It should say "this is a git repo, but not a vintage I understand".
> Not "this isn't a git repo, I'll keep looking".
>
> 2. How does a git version of the correct vintage decide "this is a git
> repo, so I'll check its config for extensions.refBackend, and a-ha,
> they _do_ have a HEAD". There's a chicken-and-egg problem.
Yes, exactly.
next prev parent reply other threads:[~2017-07-27 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 22:00 Should "head" also work for "HEAD" on case-insensitive FS? Ævar Arnfjörð Bjarmason
2017-07-04 7:19 ` Konstantin Khomoutov
2017-07-04 8:24 ` Ævar Arnfjörð Bjarmason
2017-07-05 8:36 ` Jeff King
2017-07-05 17:07 ` Junio C Hamano
2017-07-06 22:34 ` Junio C Hamano
[not found] ` <CAMy9T_FmE=8xzjRJJRxLwQjoMStJx5sYO_xtODv2OEZm54DurA@mail.gmail.com>
2017-07-27 0:23 ` Fwd: " Michael Haggerty
[not found] ` <xmqqa84c6v41.fsf@gitster.mtv.corp.google.com>
2017-07-27 0:49 ` Junio C Hamano
2017-07-27 14:35 ` Jeff King
2017-07-27 15:26 ` Junio C Hamano [this message]
2017-07-06 3:35 ` Kenneth Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgn9oq8q.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).