From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Thomas Rast" <tr@thomasrast.ch>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Philip Oakley" <philipoakley@iee.org>
Subject: Re: [PATCH v2 3/7] perf/aggregate: implement codespeed JSON output
Date: Thu, 28 Dec 2017 11:47:32 -0800 [thread overview]
Message-ID: <xmqqlghmk52j.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171226215908.425-4-chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 26 Dec 2017 22:59:04 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> ...
> +sub print_codespeed_results {
> + my ($results_section) = @_;
> +
> + #use Data::Dumper qw/ Dumper /;
> + #print Dumper(\@data);
Perhaps lose these. It is OK to keep the code live and hide it
behind --debug or something, but it seems to me that you are done
debugging it pretty much so...
> + use JSON;
Have this at the top, perhaps? It's not like this would let us
avoid loading JSON module when not doing codespeed (you need
'require' for that, right?).
> + print to_json(\@data, {utf8 => 1, pretty => 1}), "\n";
> +}
> +
> binmode STDOUT, ":utf8" or die "PANIC on binmode: $!";
>
> -print_default_results();
> +if ($codespeed) {
> + print_codespeed_results($results_section);
> +} else {
> + print_default_results();
> +}
next prev parent reply other threads:[~2017-12-28 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 21:59 [PATCH v2 0/7] Codespeed perf results Christian Couder
2017-12-26 21:59 ` [PATCH v2 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION} Christian Couder
2017-12-28 19:40 ` Junio C Hamano
2017-12-26 21:59 ` [PATCH v2 2/7] perf/aggregate: refactor printing results Christian Couder
2017-12-26 21:59 ` [PATCH v2 3/7] perf/aggregate: implement codespeed JSON output Christian Couder
2017-12-28 19:47 ` Junio C Hamano [this message]
2017-12-26 21:59 ` [PATCH v2 4/7] perf/run: add conf_opts argument to get_var_from_env_or_config() Christian Couder
2017-12-26 21:59 ` [PATCH v2 5/7] perf/run: learn about perf.codespeedOutput Christian Couder
2017-12-26 21:59 ` [PATCH v2 6/7] perf/run: learn to send output to codespeed server Christian Couder
2017-12-26 21:59 ` [PATCH v2 7/7] perf/run: read GIT_TEST_REPO_NAME from perf.repoName Christian Couder
2017-12-26 22:07 ` [PATCH v2 0/7] Codespeed perf results Christian Couder
2017-12-28 19:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlghmk52j.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).