From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Andrii Dehtiarov" <adehtiarov@google.com>
Subject: Re: [PATCH 3/3] gc: do not return error for prior errors in daemonized mode
Date: Wed, 18 Jul 2018 11:19:01 -0700 [thread overview]
Message-ID: <xmqqlga8jtka.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180718172225.GA2677@sigill.intra.peff.net> (Jeff King's message of "Wed, 18 Jul 2018 13:22:25 -0400")
Jeff King <peff@peff.net> writes:
>> Perhaps we should exit with 2 (not 0) in that "previous error" case
>> by default, and then have a configuration knob to turn that 2 into 0
>> for those who cannot easily modify the calling script? That way, we
>> by default will *not* break those who have been paying attention to
>> zero-ness of the exit status, we allow those who want to treat this
>> "prior error" case as if there were no error with just a knob, and
>> then those who are willing to update their script can tell two cases
>> by the exit status and act differently.
>
> I think we have been exiting non-zero with "previous errors" for some
> time with the daemonizing code. It was just spelled "-1" instead of "2".
> So just jumping right there does not mean any regression from the
> current state, I don't think (but it also does not fix existing scripts
> like "repo" that check the code).
Correct. That is why I suggested that default setting.
However.
If we change it so that by default we exit with 0 but allow those
who care to see 2 with a knob, that would be a regression to those
who actually were acting on the non-zero exit, but they no longer
have to scrape the log/warning output if they choose to set the
knob, so the "convenience" factor might argue in favor of the "by
default we return 0 but you can choose to get the 'sensible exit
codes'" approach. I do not have a strong opinion either way wrt
which one should be the default.
> I agree the config you suggest would give people the tools to make that
> case work. But it somehow rubs me the wrong way. Can you imagine the
> perspective of a user who is told "oh, your script breaks? Just try
> setting this option to ignore error codes in this one particular
> situation". It feels like a weird hack, because it is.
Well, the message is "your script is broken (and has always been
when 'gc --auto' saw that the previous round failed), but now we
have two ways to help you correct. An easier but broken way is to
turn this knob to turn 2 to 0 to hide the issue under the rug; or
you can notice the difference between $?==1 and $?==2 and act
differently". "turn 2 to 0" is a weird hack, but they are also
given the option of doing the right thing, so...
> It's also still inconsistent in the daemonize case. The run that yields
> the error won't return a non-zero exit. But the next run will exit with
> "2".
I do not see this particular "inconsistency" a problem. The run
that first discovers the problem by definition cannot return with
non-zero; not waiting until finding out the outcome is the whole
point of running in the background and giving control back early.
next prev parent reply other threads:[~2018-07-18 18:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 17:27 [PATCH] gc: do not warn about too many loose objects Jonathan Tan
2018-07-16 17:51 ` Jeff King
2018-07-16 18:22 ` Jonathan Nieder
2018-07-16 18:52 ` Jeff King
2018-07-16 19:09 ` Jonathan Nieder
2018-07-16 19:41 ` Jeff King
2018-07-16 19:54 ` Jonathan Nieder
2018-07-16 20:29 ` Jeff King
2018-07-16 20:37 ` Jonathan Nieder
2018-07-16 21:09 ` Jeff King
2018-07-16 21:40 ` Jonathan Nieder
2018-07-16 21:45 ` Jeff King
2018-07-16 22:03 ` Jonathan Nieder
2018-07-16 22:43 ` Jeff King
2018-07-16 22:56 ` Jonathan Nieder
2018-07-16 23:26 ` Jeff King
2018-07-17 1:53 ` Jonathan Nieder
2018-07-17 8:59 ` Ævar Arnfjörð Bjarmason
2018-07-17 14:03 ` Jonathan Nieder
2018-07-17 15:24 ` Ævar Arnfjörð Bjarmason
2018-07-17 20:27 ` Jeff King
2018-07-18 13:11 ` Ævar Arnfjörð Bjarmason
2018-07-18 17:29 ` Jeff King
2018-07-17 15:59 ` Duy Nguyen
2018-07-17 18:09 ` Junio C Hamano
2018-07-16 19:15 ` Elijah Newren
2018-07-16 19:19 ` Jonathan Nieder
2018-07-16 20:21 ` Elijah Newren
2018-07-16 20:35 ` Jeff King
2018-07-16 20:56 ` Jonathan Nieder
2018-07-16 21:12 ` Jeff King
2018-07-16 19:52 ` Jeff King
2018-07-16 20:16 ` Elijah Newren
2018-07-16 20:38 ` Jeff King
2018-07-16 21:09 ` Elijah Newren
2018-07-16 21:21 ` Jeff King
2018-07-16 22:07 ` Elijah Newren
2018-07-16 22:55 ` Jeff King
2018-07-16 23:06 ` Elijah Newren
2018-07-16 21:31 ` Jonathan Nieder
2018-07-17 6:51 ` [PATCH v2 0/3] gc --auto: do not return error for prior errors in daemonized mode Jonathan Nieder
2018-07-17 6:53 ` [PATCH 1/3] gc: improve handling of errors reading gc.log Jonathan Nieder
2018-07-17 18:19 ` Junio C Hamano
2018-07-17 19:58 ` Jeff King
2018-07-17 6:54 ` [PATCH 2/3] gc: exit with status 128 on failure Jonathan Nieder
2018-07-17 18:22 ` Junio C Hamano
2018-07-17 19:59 ` Jeff King
2018-09-17 18:33 ` Jeff King
2018-09-17 18:40 ` Jonathan Nieder
2018-09-18 17:30 ` Jeff King
2018-07-17 6:57 ` [PATCH 3/3] gc: do not return error for prior errors in daemonized mode Jonathan Nieder
2018-07-17 20:13 ` Jeff King
2018-07-18 16:21 ` Junio C Hamano
2018-07-18 17:22 ` Jeff King
2018-07-18 18:19 ` Junio C Hamano [this message]
2018-07-18 19:06 ` Jeff King
2018-07-18 19:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlga8jtka.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=adehtiarov@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).