From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Derrick Stolee <dstolee@microsoft.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] midx.c: mark a file-local symbol as static
Date: Mon, 17 Sep 2018 13:47:57 -0700 [thread overview]
Message-ID: <xmqqlg7z6ebm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com> (Derrick Stolee's message of "Mon, 17 Sep 2018 16:11:59 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> Thanks for catching this, Ramsay. Sorry for the mistake.
>
> ds/multi-pack-verify is currently queued for 'next', so I wasn't
> planning on sending another version.
Marked for 'next' does not mean we cannot touch it. It merely means
"so far no issue that requires a reroll has been raised afaik", and
the whole point of marking it is to give people a chance to stop it
before getting merged to 'next' with known issues.
As the problematic commit is not in 'next', let's squash the fix in.
Thanks, both.
prev parent reply other threads:[~2018-09-17 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 23:26 [PATCH] midx.c: mark a file-local symbol as static Ramsay Jones
2018-09-17 20:11 ` Derrick Stolee
2018-09-17 20:44 ` Junio C Hamano
2018-09-17 20:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg7z6ebm.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).