From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Carlo Arenas <carenas@gmail.com>,
git@vger.kernel.org, stolee@gmail.com, avarab@gmail.com,
pclouds@gmail.com, szeder.dev@gmail.com
Subject: Re: [PATCH v4 10/12] Add a base implementation of SHA-256 support
Date: Thu, 01 Nov 2018 14:29:06 +0900 [thread overview]
Message-ID: <xmqqlg6dtlgd.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181031225521.GA573515@genre.crustytoothpaste.net> (brian m. carlson's message of "Wed, 31 Oct 2018 22:55:21 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> I need to do a reroll to address some other issues people brought up, so
> I can remove this line.
OK. I actually do not feel too strongly about this one, by the way.
next prev parent reply other threads:[~2018-11-01 5:29 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 2:39 [PATCH v4 00/12] Base SHA-256 implementation brian m. carlson
2018-10-25 2:39 ` [PATCH v4 01/12] sha1-file: rename algorithm to "sha1" brian m. carlson
2018-10-25 2:39 ` [PATCH v4 02/12] sha1-file: provide functions to look up hash algorithms brian m. carlson
2018-10-25 2:39 ` [PATCH v4 03/12] hex: introduce functions to print arbitrary hashes brian m. carlson
2018-10-25 2:39 ` [PATCH v4 04/12] cache: make hashcmp and hasheq work with larger hashes brian m. carlson
2018-10-25 2:39 ` [PATCH v4 05/12] t: add basic tests for our SHA-1 implementation brian m. carlson
2018-10-25 2:39 ` [PATCH v4 06/12] t: make the sha1 test-tool helper generic brian m. carlson
2018-10-25 2:40 ` [PATCH v4 07/12] sha1-file: add a constant for hash block size brian m. carlson
2018-10-25 2:40 ` [PATCH v4 08/12] t/helper: add a test helper to compute hash speed brian m. carlson
2018-10-25 2:40 ` [PATCH v4 09/12] commit-graph: convert to using the_hash_algo brian m. carlson
2018-10-25 2:40 ` [PATCH v4 10/12] Add a base implementation of SHA-256 support brian m. carlson
2018-10-25 3:02 ` Carlo Arenas
2018-10-28 15:52 ` brian m. carlson
2018-10-29 0:39 ` Junio C Hamano
2018-10-31 22:55 ` brian m. carlson
2018-11-01 5:29 ` Junio C Hamano [this message]
2018-10-27 9:03 ` Christian Couder
2018-10-25 2:40 ` [PATCH v4 11/12] sha256: add an SHA-256 implementation using libgcrypt brian m. carlson
2018-10-25 2:40 ` [PATCH v4 12/12] hash: add an SHA-256 implementation using OpenSSL brian m. carlson
2018-11-04 23:44 ` [PATCH v5 00/12] Base SHA-256 implementation brian m. carlson
2018-11-04 23:44 ` [PATCH v5 01/12] sha1-file: rename algorithm to "sha1" brian m. carlson
2018-11-05 7:21 ` Ævar Arnfjörð Bjarmason
2018-11-04 23:44 ` [PATCH v5 02/12] sha1-file: provide functions to look up hash algorithms brian m. carlson
2018-11-13 18:42 ` Derrick Stolee
2018-11-13 18:45 ` Duy Nguyen
2018-11-14 1:01 ` brian m. carlson
2018-11-14 0:11 ` Ramsay Jones
2018-11-14 0:42 ` Ramsay Jones
2018-11-14 0:51 ` Jeff King
2018-11-14 2:11 ` brian m. carlson
2018-11-14 3:53 ` Ramsay Jones
2018-11-04 23:44 ` [PATCH v5 03/12] hex: introduce functions to print arbitrary hashes brian m. carlson
2018-11-04 23:44 ` [PATCH v5 04/12] cache: make hashcmp and hasheq work with larger hashes brian m. carlson
2018-11-04 23:44 ` [PATCH v5 05/12] t: add basic tests for our SHA-1 implementation brian m. carlson
2018-11-04 23:44 ` [PATCH v5 06/12] t: make the sha1 test-tool helper generic brian m. carlson
2018-11-04 23:44 ` [PATCH v5 07/12] sha1-file: add a constant for hash block size brian m. carlson
2018-11-04 23:44 ` [PATCH v5 08/12] t/helper: add a test helper to compute hash speed brian m. carlson
2018-11-04 23:44 ` [PATCH v5 09/12] commit-graph: convert to using the_hash_algo brian m. carlson
2018-11-04 23:44 ` [PATCH v5 10/12] Add a base implementation of SHA-256 support brian m. carlson
2018-11-05 11:39 ` Ævar Arnfjörð Bjarmason
2018-11-07 1:30 ` brian m. carlson
2018-11-10 15:52 ` Ævar Arnfjörð Bjarmason
2018-11-04 23:44 ` [PATCH v5 11/12] sha256: add an SHA-256 implementation using libgcrypt brian m. carlson
2018-11-04 23:44 ` [PATCH v5 12/12] hash: add an SHA-256 implementation using OpenSSL brian m. carlson
2018-11-05 2:45 ` [PATCH v5 00/12] Base SHA-256 implementation Junio C Hamano
2018-11-14 4:09 ` [PATCH v6 " brian m. carlson
2018-11-14 4:09 ` [PATCH v6 01/12] sha1-file: rename algorithm to "sha1" brian m. carlson
2018-11-14 4:09 ` [PATCH v6 02/12] sha1-file: provide functions to look up hash algorithms brian m. carlson
2018-11-14 4:09 ` [PATCH v6 03/12] hex: introduce functions to print arbitrary hashes brian m. carlson
2018-11-14 4:09 ` [PATCH v6 04/12] cache: make hashcmp and hasheq work with larger hashes brian m. carlson
2018-11-14 4:09 ` [PATCH v6 05/12] t: add basic tests for our SHA-1 implementation brian m. carlson
2018-11-14 4:09 ` [PATCH v6 06/12] t: make the sha1 test-tool helper generic brian m. carlson
2018-11-14 4:09 ` [PATCH v6 07/12] sha1-file: add a constant for hash block size brian m. carlson
2018-11-14 4:09 ` [PATCH v6 08/12] t/helper: add a test helper to compute hash speed brian m. carlson
2018-11-14 4:09 ` [PATCH v6 09/12] commit-graph: convert to using the_hash_algo brian m. carlson
2018-11-14 4:09 ` [PATCH v6 10/12] Add a base implementation of SHA-256 support brian m. carlson
2018-11-14 4:09 ` [PATCH v6 11/12] sha256: add an SHA-256 implementation using libgcrypt brian m. carlson
2018-11-14 4:09 ` [PATCH v6 12/12] hash: add an SHA-256 implementation using OpenSSL brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg6dtlgd.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).