git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] .mailmap: record canonical email address for Sven Strickroth
@ 2018-11-20 19:40 Sven Strickroth
  2018-11-20 21:58 ` Jonathan Nieder
  0 siblings, 1 reply; 3+ messages in thread
From: Sven Strickroth @ 2018-11-20 19:40 UTC (permalink / raw)
  To: git; +Cc: gitster

Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
 .mailmap | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.mailmap b/.mailmap
index f165222a78..a30f409f39 100644
--- a/.mailmap
+++ b/.mailmap
@@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
 Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
 Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
 Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
+Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>
+Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>
 Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
 Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
 SZEDER Gábor <szeder.dev@gmail.com> <szeder@ira.uka.de>
-- 
2.19.1.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth
  2018-11-20 19:40 [PATCH] .mailmap: record canonical email address for Sven Strickroth Sven Strickroth
@ 2018-11-20 21:58 ` Jonathan Nieder
  2018-11-21  0:00   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2018-11-20 21:58 UTC (permalink / raw)
  To: Sven Strickroth; +Cc: git, gitster

Hi,

Sven Strickroth wrote:

> Subject: .mailmap: record canonical email address for Sven Strickroth
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
>  .mailmap | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for taking care of it.

[...]
> --- a/.mailmap
> +++ b/.mailmap
> @@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
>  Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>

Is the above line needed?  It's not clear to me from the commit message
what it does.

> +Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>

This line looks good.

>  Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
>  Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
>  SZEDER G??bor <szeder.dev@gmail.com> <szeder@ira.uka.de>

This line does not seem to have survived mailing.  Fortunately it's a
context line, but thought I should mention it for the future.

Thanks and hope that helps,
Jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth
  2018-11-20 21:58 ` Jonathan Nieder
@ 2018-11-21  0:00   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2018-11-21  0:00 UTC (permalink / raw)
  To: Jonathan Nieder; +Cc: Sven Strickroth, git

Jonathan Nieder <jrnieder@gmail.com> writes:

>> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>
>
> Is the above line needed?  It's not clear to me from the commit message
> what it does.

Stare at it once again and you'll see ;-) FWIW I needed to do that
myself before you had the same issue.

Sven is trying to hide real-name name and have a bland token that
would leave the least amount of impression to the recipients there
instead, i.e. "email@add.re.ss".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-21  0:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 19:40 [PATCH] .mailmap: record canonical email address for Sven Strickroth Sven Strickroth
2018-11-20 21:58 ` Jonathan Nieder
2018-11-21  0:00   ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).