From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] Makefile: dedup list of files obtained from ls-files
Date: Wed, 24 Apr 2019 10:03:37 +0900 [thread overview]
Message-ID: <xmqqlg0043km.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190423202109.GA8695@szeder.dev> ("SZEDER Gábor"'s message of "Tue, 23 Apr 2019 22:21:09 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> I remember being rather puzzled by 'git ls-files' listing the same
> file more than once depending on its --options when I was working on
> the git-aware path completion parts of our completion script.
Yup, I recall a thread we recently had where we wondered why we see
two entries reported when we ask for 'modified' and 'deleted' at the
same time.
Perhaps not-so-low-hanging fruit miniproject would be to teach
"ls-files" a new "--dedup" option that does two things:
* When -m and -d are asked at the same time, ignore '-d', because
'-d' will give duplicates for subsets of what '-m' would show
anyway; and
* When neither -s nor -u is given, do not show the same path more
than once, even the ones with multiple stages.
next prev parent reply other threads:[~2019-04-24 1:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 13:19 [PATCH/RFC] Makefile: dedup list of files obtained from ls-files Junio C Hamano
2019-04-22 3:23 ` Eric Sunshine
2019-04-22 6:11 ` Junio C Hamano
2019-04-22 14:49 ` Jeff King
2019-04-22 17:15 ` Ramsay Jones
2019-04-23 1:18 ` Junio C Hamano
2019-04-23 20:21 ` SZEDER Gábor
2019-04-24 1:03 ` Junio C Hamano [this message]
2019-04-24 11:25 ` SZEDER Gábor
2019-04-24 17:19 ` Eric Sunshine
2019-04-25 0:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg0043km.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).