git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, rsbecker@nexbridge.com,
	johannes.schindelin@gmx.de, larsxschneider@gmail.com,
	szeder.dev@gmail.com
Subject: Re: [PATCH] t0021: make sure clean filter runs
Date: Tue, 20 Aug 2019 11:01:58 -0700	[thread overview]
Message-ID: <xmqqlfvnvhpl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190820065625.128130-1-t.gummerer@gmail.com> (Thomas Gummerer's message of "Tue, 20 Aug 2019 07:56:25 +0100")

Thomas Gummerer <t.gummerer@gmail.com> writes:

> Fix the test by updating the mtime of test.r, so git is forced to
> check the contents of the file, and the clean filter is run as the
> test expects.

Hmph, depending on the timestamp granularity, with this patch,
test.r would have mtime that is the same or a bit later than that of
the index file.  Is it sufficient to really "force" Git to check the
contents, or does it just make the likelyhood that it would choose
to check a bit bigger (in other words, are we solving the race, or
merely making the race window smaller)?

Thanks.

>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
>  t/t0021-conversion.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
> index e10f5f787f..66f75005d5 100755
> --- a/t/t0021-conversion.sh
> +++ b/t/t0021-conversion.sh
> @@ -390,6 +390,7 @@ test_expect_success PERL 'required process filter should filter data' '
>  		EOF
>  		test_cmp_exclude_clean expected.log debug.log &&
>  
> +		touch test.r &&
>  		filter_git checkout --quiet --no-progress empty-branch &&
>  		cat >expected.log <<-EOF &&
>  			START

  reply	other threads:[~2019-08-20 18:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  6:56 [PATCH] t0021: make sure clean filter runs Thomas Gummerer
2019-08-20 18:01 ` Junio C Hamano [this message]
2019-08-21 14:52   ` Thomas Gummerer
2019-08-21 15:40     ` Junio C Hamano
2019-08-20 19:11 ` Johannes Sixt
2019-08-21 14:56   ` Thomas Gummerer
2019-08-21 18:23     ` Johannes Sixt
2019-08-21 22:03       ` SZEDER Gábor
2019-08-22 17:49         ` Thomas Gummerer
2019-08-22 18:04           ` Junio C Hamano
2019-08-22 18:52           ` Johannes Sixt
2019-08-22 19:22 ` [PATCH v2] " Thomas Gummerer
2019-08-22 20:01   ` Junio C Hamano
2019-08-23  8:34   ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfvnvhpl.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=larsxschneider@gmail.com \
    --cc=rsbecker@nexbridge.com \
    --cc=szeder.dev@gmail.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).