git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kevin Willford via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Kevin Willford <Kevin.Willford@microsoft.com>
Subject: Re: [PATCH 0/1] fsmonitor: fix watchman integration
Date: Wed, 06 Nov 2019 12:29:58 +0900	[thread overview]
Message-ID: <xmqqlfstvg09.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <pull.444.git.1572889841.gitgitgadget@gmail.com> (Kevin Willford via GitGitGadget's message of "Mon, 04 Nov 2019 17:50:40 +0000")

"Kevin Willford via GitGitGadget" <gitgitgadget@gmail.com> writes:

> When running Git commands quickly -- such as in a shell script or the test
> suite -- the Git commands frequently complete and start again during the
> same second. The example fsmonitor hooks to integrate with Watchman truncate
> the nanosecond times to seconds. In principle, this is fine, as Watchman
> claims to use inclusive comparisons [1]. The result should only be an
> over-representation of the changed paths since the last Git command.
> ...

So, it doesn't seem to use "inclusive" and we need a workaround?

> Kevin Willford (1):
>   fsmonitor: fix watchman integration
>
>  t/t7519/fsmonitor-watchman                 | 13 ++++---------
>  templates/hooks--fsmonitor-watchman.sample | 13 ++++---------
>  2 files changed, 8 insertions(+), 18 deletions(-)

Thanks, will queue.

  parent reply	other threads:[~2019-11-06  3:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 17:50 [PATCH 0/1] fsmonitor: fix watchman integration Kevin Willford via GitGitGadget
2019-11-04 17:50 ` [PATCH 1/1] " Kevin Willford via GitGitGadget
2019-11-12 11:32   ` SZEDER Gábor
2019-11-06  3:29 ` Junio C Hamano [this message]
2019-11-06 15:32   ` [PATCH 0/1] " Kevin Willford
2019-11-06 15:46     ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfstvg09.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Kevin.Willford@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).