From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id BF63F1F463 for ; Mon, 6 Jan 2020 17:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgAFRN5 (ORCPT ); Mon, 6 Jan 2020 12:13:57 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:56500 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgAFRN4 (ORCPT ); Mon, 6 Jan 2020 12:13:56 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 47A77223D0; Mon, 6 Jan 2020 12:13:55 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=woM7kcU6dWU4zi+RjX2kif5JKYY=; b=vl8Put 8nDOWQ8xLWRMzqRIBXgNNoqYyKYWE8oi7xiwiWRIcrA/4k/E6o0shJgtZ1GpVSaT oCzqh2Whr5jIEbGyz1fFXGvyC3JMDfez89FjJ/mqfxo0ZzgmLP2sRrKFSB6WHrhO sjXStF35PxqimiLqa3VjQEmx6jwyJOWymQhGw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=T6OXjRmdbFAKeiknCw2k3QRCM03iWSAA k1JZ9G1x6QzhLQ4C4P3+RJmX1ZbIH/pULEQ4VSNfOwuoIo5vKN1BtlicEvfp1JwY qnLmomUFLPnTNa+B3d+WE7r8bLq7A8KDat3L5/mD5WbFZZUJ2kYkwjMGqH0a8OU2 +JnS0xlxo60= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 3F179223CF; Mon, 6 Jan 2020 12:13:55 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 97139223CE; Mon, 6 Jan 2020 12:13:54 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "elonderin via GitGitGadget" Cc: git@vger.kernel.org, thomas menzel Subject: Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs References: Date: Mon, 06 Jan 2020 09:13:53 -0800 In-Reply-To: (elonderin via GitGitGadget's message of "Mon, 06 Jan 2020 14:50:13 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EADEDF42-30A7-11EA-80F3-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "elonderin via GitGitGadget" writes: > From: elonderin <8225602+elonderin@users.noreply.github.com> > > The sentence wants to talk about the superproject's possesive, not plural form. > > Signed-off-by: thomas menzel dev@tomsit.de The author of the patch must sign-off, so the above three lines should look more like so: From: Thomas Menzel The sentence wants to talk about the superproject's possesive, not plural form. From: Thomas Menzel The content of the patch obviously is correct. Thanks. > --- > Documentation/git-submodule.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt > index 22425cbc76..5232407f68 100644 > --- a/Documentation/git-submodule.txt > +++ b/Documentation/git-submodule.txt > @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within. > > absorbgitdirs:: > If a git directory of a submodule is inside the submodule, > - move the git directory of the submodule into its superprojects > + move the git directory of the submodule into its superproject's > `$GIT_DIR/modules` path and then connect the git directory and > its working directory by setting the `core.worktree` and adding > a .git file pointing to the git directory embedded in the