From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH] t2402: test worktree path when called in .git directory
Date: Wed, 04 Mar 2020 08:20:02 -0800 [thread overview]
Message-ID: <xmqqlfog5byl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRBNHX516_cQ_G-2azL61xOo5ndOHV_E-OmQ4XvpwBffQ@mail.gmail.com> (Eric Sunshine's message of "Wed, 4 Mar 2020 03:15:05 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Wed, Mar 4, 2020 at 2:00 AM Hariom Verma via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> The bug which reports an extra `/.git/.` in worktree path when called in
>> '.git' directory already has been fixed. But unfortunately, the regression
>> test to ensure this behavior has been forgotten.
>> Here is that test.
>
> For readers not involved in the discussion, this test was requested by
> [1], but the topic graduated to "next" before it could be re-rolled.
> It probably ought to be queued atop
> 'hv/receive-denycurrent-everywhere'.
>
> [1]: https://lore.kernel.org/git/CAPig+cTh-uu-obh9aeDOV9ptbVwRmkujgucbu9ei1Qa3qSNG_A@mail.gmail.com/
Your notes to those watching from sidelines are greatly appreciated.
>> Signed-off-by: Hariom Verma <hariom18599@gmail.com>
>> ---
>> diff --git a/t/t2402-worktree-list.sh b/t/t2402-worktree-list.sh
>> @@ -151,4 +151,10 @@ test_expect_success 'linked worktrees are sorted' '
>> +test_expect_success 'worktree path when called in .git directory' '
>> + git worktree list> list1 &&
>> + git -C .git worktree list> list2 &&
>
> Nit: Style is for the redirection operator to stick to the file:
;-) Thanks for being a careful reader.
> git worktree list >list1 &&
> git -C .git worktree list >list2 &&
>
>> + test_cmp list1 list2
>> +'
>
> The test itself makes sense.
prev parent reply other threads:[~2020-03-04 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 7:00 [PATCH] t2402: test worktree path when called in .git directory Hariom Verma via GitGitGadget
2020-03-04 8:15 ` Eric Sunshine
2020-03-04 16:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfog5byl.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).