From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2A06B1F66E for ; Fri, 14 Aug 2020 04:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726268AbgHNEpI (ORCPT ); Fri, 14 Aug 2020 00:45:08 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:55466 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbgHNEpH (ORCPT ); Fri, 14 Aug 2020 00:45:07 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id E2ECBE41F8; Fri, 14 Aug 2020 00:45:05 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=pOKTmbHpUvXvb8Ex1JMgkXMUGrw=; b=CPmwfz cGKb5EUQ6KqJ2/HtBvzTlSY8baD4sGGJUzA9Z9lb9/NBWJ++g1/cWY3AvnXpTJQO ZrMfIeWq1BU8VH0e2K9KTHHSqgGPg2OiEcqVT2BC2f5a1JKd2PUi1jsU11czgv8r Ol9Qoyc6bd14+4U8Sw4TlAjK8zLhG9zYm1+MU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=xB7n+fGbZ76bn1v7Cfmy0qP3HYmKQImp 0fK+C7Y3FNOZCilREmF6OukUa7sYWBc7P3+quJbPo2uP3bTMe4MwXl3/jVJCdZFW 5g4bdBomNvlDmHvqeogeP+rxLgI1poQ2jGWOW7itXQd3eizMx3MlFU//ibIxyosV 5ZITuSQuyOE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id DB747E41F6; Fri, 14 Aug 2020 00:45:05 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.231.104.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id AF5B9E41F3; Fri, 14 Aug 2020 00:45:02 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: git@vger.kernel.org, "brian m. carlson" Subject: Re: [PATCH] messages: avoid SHA-1 in end-user facing messages References: Date: Thu, 13 Aug 2020 21:45:01 -0700 In-Reply-To: (Derrick Stolee's message of "Thu, 13 Aug 2020 22:21:51 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EAA953B0-DDE8-11EA-A77B-F0EA2EB3C613-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Derrick Stolee writes: >> N_("Show blank SHA-1 for boundary commits (Default: off)")), >> N_("Blank object names of boundary commits (Default: off)")), > > Is there a reason you dropped "show" here? Perhaps your > intention is to use "blank" as a verb, but it read a bit > awkwardly to me. You guessed my intention correctly. By using the word "blank" as a verb (i.e. to fill the space, which should ordinarily contain something meaningful, with whitespace instead), I can shorten "Show blank" to compensate the lengthening of the message caused by replacing "SHA-1" with "object name". It also is more correct. There is no "blank SHA-1"; blank cannot be a valid SHA-1 hash value. We are showing blank instead of SHA-1, and I found that "blank" as a verb exactly has that meaning, which was convenient. The above is *NOT* to defend the choice of the exact phasing I used, but to explain the criteria we need to use to come up with a better alternative (in other words, why "show blank object name for..." is a better replacement). A better phrasing to replace it is of course welcome. Thanks.