From: Junio C Hamano <email@example.com> To: Derrick Stolee <firstname.lastname@example.org> Cc: email@example.com, "brian m. carlson" <firstname.lastname@example.org> Subject: Re: [PATCH] messages: avoid SHA-1 in end-user facing messages Date: Thu, 13 Aug 2020 21:45:01 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Derrick Stolee's message of "Thu, 13 Aug 2020 22:21:51 -0400") Derrick Stolee <email@example.com> writes: >> N_("Show blank SHA-1 for boundary commits (Default: off)")), >> N_("Blank object names of boundary commits (Default: off)")), > > Is there a reason you dropped "show" here? Perhaps your > intention is to use "blank" as a verb, but it read a bit > awkwardly to me. You guessed my intention correctly. By using the word "blank" as a verb (i.e. to fill the space, which should ordinarily contain something meaningful, with whitespace instead), I can shorten "Show blank" to compensate the lengthening of the message caused by replacing "SHA-1" with "object name". It also is more correct. There is no "blank SHA-1"; blank cannot be a valid SHA-1 hash value. We are showing blank instead of SHA-1, and I found that "blank" as a verb exactly has that meaning, which was convenient. The above is *NOT* to defend the choice of the exact phasing I used, but to explain the criteria we need to use to come up with a better alternative (in other words, why "show blank object name for..." is a better replacement). A better phrasing to replace it is of course welcome. Thanks.
next prev parent reply other threads:[~2020-08-14 4:45 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-14 1:07 Junio C Hamano 2020-08-14 1:11 ` brian m. carlson 2020-08-14 2:21 ` Derrick Stolee 2020-08-14 4:45 ` Junio C Hamano [this message] 2020-08-14 4:51 ` Eric Sunshine 2020-08-14 8:22 ` Junio C Hamano 2020-08-14 12:21 ` Derrick Stolee 2020-08-14 16:31 ` Junio C Hamano 2020-08-14 16:40 ` [PATCH v2] " Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] messages: avoid SHA-1 in end-user facing messages' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).