git commit-tree does not honor commit.gpgSign config

git commit-tree does not honor commit.gpgSign config

[Evan Grim]

Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`
configuration option?

I'm considering working up a patch to fix this, but want a quick check
from more knowledgeable sources first on what the desired behavior is.

Re: git commit-tree does not honor commit.gpgSign config

[Junio C Hamano]

Evan Grim <evangrim@gmail.com> writes:

> Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`
> configuration option?

It would be a bug if it did, as a low level plumbing tool to build
scripts around, it would not want its behaviour to be affected by
end-user configuration (rather, scripts that are written using these
plumbing command do want to handle end-user customization their own
ways).

Re: git commit-tree does not honor commit.gpgSign config

[Evan Grim]

Thank you for that context.  I came across this when I used
`git-subtree` and was surprised the commits it created weren't signed.
Would it be appropriate to look into patching `git-subtree` to honor
the configuration option?

On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Evan Grim <evangrim@gmail.com> writes:
>
> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`
> > configuration option?
>
> It would be a bug if it did, as a low level plumbing tool to build
> scripts around, it would not want its behaviour to be affected by
> end-user configuration (rather, scripts that are written using these
> plumbing command do want to handle end-user customization their own
> ways).

Re: git commit-tree does not honor commit.gpgSign config

[Junio C Hamano]

Evan Grim <evangrim@gmail.com> writes:

> On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Evan Grim <evangrim@gmail.com> writes:
>>
>> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`
>> > configuration option?
>>
>> It would be a bug if it did, as a low level plumbing tool to build
>> scripts around, it would not want its behaviour to be affected by
>> end-user configuration (rather, scripts that are written using these
>> plumbing command do want to handle end-user customization their own
>> ways).
>
> Thank you for that context.  I came across this when I used
> `git-subtree` and was surprised the commits it created weren't signed.
> Would it be appropriate to look into patching `git-subtree` to honor
> the configuration option?

Yes, the script that invokes "commit-tree" is at the right layer to
notice commit.gpgsign and possibly $name_of_the_script.gpgsign
configuration variable(s) and add the -S option, I would think.

I do not know if there are people who are still using, or who is
maintaining, the "subtree" script, though.

Thanks.