From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 477411F4B4 for ; Mon, 28 Sep 2020 23:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbgI1XO0 (ORCPT ); Mon, 28 Sep 2020 19:14:26 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61876 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727203AbgI1XOP (ORCPT ); Mon, 28 Sep 2020 19:14:15 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 13E118E72D; Mon, 28 Sep 2020 18:37:02 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=04F/lRhz9BF1tUSs8bgYcq33VB0=; b=P3HqHg QdEgzj+fB9TMBIcMnGTWsIPPAbHwGsaOkfFbdtq3LsmN4qboQIbYdd+L9Mbmbx6/ JGN3myE9JN9RHhykqyAD6e4tYaMnY+PFIakJC6apu5BbLzJw4lFBweT+dAfiluaG Z5L1ghcbWr9pMvMFZdfXPez85EGPvS22o46oo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=IA0rgpVJCiWEyNwckC9ydggimrCYUtQC nD0OVi4SBNduGQANucMQVU6hV4Uhfr92GVoX+ZvmsJmWj7Vt0BmhPxgvyEiVt4ii 0Dmlh2KdlD3EB3iW+XFSNcoUyIOxmIENMlSv0sKyXo2PAU8UM/iSloa3Ll1G1hy/ jVdqzM/xwH0= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id B43818E72C; Mon, 28 Sep 2020 18:37:01 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 000298E72A; Mon, 28 Sep 2020 18:37:00 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Evan Grim Cc: git@vger.kernel.org Subject: Re: git commit-tree does not honor commit.gpgSign config References: Date: Mon, 28 Sep 2020 15:37:00 -0700 In-Reply-To: (Evan Grim's message of "Mon, 28 Sep 2020 13:42:43 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 1FEF53E2-01DB-11EB-8784-2F5D23BA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Evan Grim writes: > On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano wrote: >> >> Evan Grim writes: >> >> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign` >> > configuration option? >> >> It would be a bug if it did, as a low level plumbing tool to build >> scripts around, it would not want its behaviour to be affected by >> end-user configuration (rather, scripts that are written using these >> plumbing command do want to handle end-user customization their own >> ways). > > Thank you for that context. I came across this when I used > `git-subtree` and was surprised the commits it created weren't signed. > Would it be appropriate to look into patching `git-subtree` to honor > the configuration option? Yes, the script that invokes "commit-tree" is at the right layer to notice commit.gpgsign and possibly $name_of_the_script.gpgsign configuration variable(s) and add the -S option, I would think. I do not know if there are people who are still using, or who is maintaining, the "subtree" script, though. Thanks.