git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sibo Dong <sibo.dong@mail.utoronto.ca>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	"gitgitgadget@gmail.com" <gitgitgadget@gmail.com>,
	"sibo.dong@outlook.com" <sibo.dong@outlook.com>
Subject: Re: [PATCH] git-prompt.sh: make `option` a local variable
Date: Mon, 02 Nov 2020 12:39:57 -0800	[thread overview]
Message-ID: <xmqqlffjtrvm.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: 1d19cdf35c12b1079cee0861469dc1a652642c82.camel@mail.utoronto.ca

Sibo Dong <sibo.dong@mail.utoronto.ca> writes:

> Thank you for the feedback Junio; I'm a bit new to contributing. Since
> you've justified this change much better than I have, is there any need
> for further action on my part?

The reviews by others are offered and taken as input to improve the
patch(es), but they are merely sugestions.  It is up to the original
contributors to either disagree and not take them with explanation,
or agree with and take them to improve their patch(es) before
sending the next iteration.

So, at least you'd need to say if you agree with the suggested
change and to what degree.  Since you've done so, I can save one
roundtrip by rewriting the proposed commit log message myself while
queuing your patch ;-)

Thanks.


      reply	other threads:[~2020-11-02 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 22:09 [PATCH] git-prompt.sh: make `option` a local variable Sibo Dong via GitGitGadget
2020-10-31 22:45 ` Junio C Hamano
2020-11-01  8:04   ` Sibo Dong
2020-11-02 20:39     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlffjtrvm.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sibo.dong@mail.utoronto.ca \
    --cc=sibo.dong@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).