From: Junio C Hamano <gitster@pobox.com> To: Jeff King <peff@peff.net> Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org, "Johannes Schindelin" <johannes.schindelin@gmx.de> Subject: Re: [PATCH 1/2] tests: make sure nested lazy prereqs work reliably Date: Thu, 19 Nov 2020 17:32:36 -0800 Message-ID: <xmqqlfewvmmj.fsf@gitster.c.googlers.com> (raw) In-Reply-To: <20201120001458.GA274082@coredump.intra.peff.net> (Jeff King's message of "Thu, 19 Nov 2020 19:14:58 -0500") Jeff King <peff@peff.net> writes: > OK, then here's the whole thing. I ended up with a few more cleanups, > too. This is all on top of Gábor's patches. It's conceptually > independent, but the textual wrangling was annoying enough it didn't > make any sense to require you to do it again during merging. ;) Plus I > do not think either topic is high-risk nor urgent enough to worry too > much about one blocking the other. I'll ask you to do the last step maybe in a few weeks; the range notation tests seem to have changed since where I queued Gábor's patches and where [4/4] is based on (yours is based on newer codebase). > The diffstat is scary, but it's mostly the final patch, which is pretty > mechanical. Yup, and the result is much easier to read. Thanks. > [1/4]: t0000: keep clean-up tests together > [2/4]: t0000: run prereq tests inside sub-test > [3/4]: t0000: run cleaning test inside sub-test > [4/4]: t0000: consistently use single quotes for outer tests > > t/t0000-basic.sh | 570 +++++++++++++++++++++++------------------------ > 1 file changed, 284 insertions(+), 286 deletions(-) > > -Peff
next prev parent reply other threads:[~2020-11-20 1:35 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 19:04 SZEDER Gábor 2020-11-18 19:04 ` [PATCH 2/2] tests: fix description of 'test_set_prereq' SZEDER Gábor 2020-11-18 20:00 ` [PATCH 1/2] tests: make sure nested lazy prereqs work reliably Junio C Hamano 2020-11-19 15:58 ` Jeff King 2020-11-19 17:56 ` Jeff King 2020-11-19 19:50 ` Junio C Hamano 2020-11-20 0:14 ` Jeff King 2020-11-20 0:17 ` [PATCH 1/4] t0000: keep clean-up tests together Jeff King 2020-11-20 0:20 ` [PATCH 2/4] t0000: run prereq tests inside sub-test Jeff King 2020-11-20 0:22 ` [PATCH 3/4] t0000: run cleaning test " Jeff King 2020-11-20 0:27 ` [PATCH 4/4] t0000: consistently use single quotes for outer tests Jeff King 2020-11-20 1:32 ` Junio C Hamano [this message] 2020-11-20 0:07 ` [PATCH 1/2] tests: make sure nested lazy prereqs work reliably Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqlfewvmmj.fsf@gitster.c.googlers.com \ --to=gitster@pobox.com \ --cc=git@vger.kernel.org \ --cc=johannes.schindelin@gmx.de \ --cc=peff@peff.net \ --cc=szeder.dev@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git