From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Andrei Rybak" <rybak.a.v@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs
Date: Thu, 17 Jun 2021 09:29:18 +0900 [thread overview]
Message-ID: <xmqqlf79nxk1.fsf@gitster.g> (raw)
In-Reply-To: <YMnllMXvRJKSdGID@coredump.intra.peff.net> (Jeff King's message of "Wed, 16 Jun 2021 07:50:44 -0400")
Jeff King <peff@peff.net> writes:
> My thought was that the subshell takes us back to the original state,
> regardless of what it was. As opposed to "set +f" which takes us back to
> a particular state. But it is unlikely that we'd have done a global "set
> -f" before calling this, so maybe that is being overly conservative.
Overly conservative, yes, but if it is not too much overhead, I
think it is a good practice anyway.
next prev parent reply other threads:[~2021-06-17 0:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 20:55 [BUG] question mark in GIT_SKIP_TESTS is broken in master Andrei Rybak
2021-06-15 23:28 ` [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master) Andrei Rybak
2021-06-16 3:28 ` Junio C Hamano
2021-06-16 4:12 ` Junio C Hamano
2021-06-16 8:29 ` Jeff King
2021-06-16 9:19 ` Junio C Hamano
2021-06-16 8:24 ` [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs Ævar Arnfjörð Bjarmason
2021-06-16 8:36 ` Jeff King
2021-06-16 9:22 ` Junio C Hamano
2021-06-16 10:23 ` Jeff King
2021-06-16 10:24 ` Jeff King
2021-06-16 11:38 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:50 ` Jeff King
2021-06-17 0:29 ` Junio C Hamano [this message]
2021-06-16 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-16 11:43 ` Jeff King
2021-06-17 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlf79nxk1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).