From: Junio C Hamano <gitster@pobox.com>
To: "Tal Kelrich via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Tal Kelrich <hasturkun@gmail.com>
Subject: Re: [PATCH] fast-export: fix anonymized tag using original length
Date: Tue, 31 Aug 2021 12:10:05 -0700 [thread overview]
Message-ID: <xmqqlf4htoqa.fsf@gitster.g> (raw)
In-Reply-To: <pull.1030.git.1630425354496.gitgitgadget@gmail.com> (Tal Kelrich via GitGitGadget's message of "Tue, 31 Aug 2021 15:55:54 +0000")
"Tal Kelrich via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Tal Kelrich <hasturkun@gmail.com>
>
> Commit 7f4075949686 (fast-export: tighten anonymize_mem() interface to
> handle only strings, 2020-06-23) changed the interface used in anonymizing
> strings, but failed to update the size of annotated tag messages to match
> the new anonymized string.
>
> As a result, exporting tags having messages longer than 13 characters
> would create output that couldn't be parsed by fast-import,
> as the data length indicated was larger than the data output.
>
> Reset the message size when anonymizing, and add a tag with a "long"
> message to the test.
>
> Signed-off-by: Tal Kelrich <hasturkun@gmail.com>
> ---
> fast-export: fix anonymized tag using original length
>
> Fixes an issue with fast-export anonymization, where any original
> annotated tag message longer than 13 characters would make the output
> unimportable by fast-import (as the data length indicated the original
> length).
>
> This also resolves a more minor issue, where if the original message was
> short, the anonymized tag message would be truncated.
Thanks. I've looked at all places where anonymize_str() is used and
found that this is the only problematic caller.
Will queue.
next prev parent reply other threads:[~2021-08-31 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 15:55 [PATCH] fast-export: fix anonymized tag using original length Tal Kelrich via GitGitGadget
2021-08-31 19:10 ` Junio C Hamano [this message]
2021-08-31 19:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlf4htoqa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hasturkun@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).