From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Konstantin Khomoutov <kostix@bswap.ru>, git@vger.kernel.org
Subject: Re: [RFC] shell: local x=$1 may need to quote the RHS
Date: Wed, 26 Jan 2022 16:17:02 -0800 [thread overview]
Message-ID: <xmqqlez2nibl.fsf@gitster.g> (raw)
In-Reply-To: <YfHCoR2VSad95Cpu@nand.local> (Taylor Blau's message of "Wed, 26 Jan 2022 16:52:33 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> On Tue, Jan 25, 2022 at 09:53:25PM -0800, Junio C Hamano wrote:
>> Taylor Blau <me@ttaylorr.com> writes:
>> >
>> >> The manual page for recent dash may need an update.
>> >> Can you perhaps file a bug on their documentation?
>> >
>> > Yes, I agree that dash.1 is out-of-date after cbb71a8. Konstantin:
>> > please feel free to use any of this if it's helpful to you in creating a
>> > bug report for the dash folks.
>>
>> I doubt that we can write off dash v0.5.10 as too old to matter, as
>> the tagger date seems to be mid 2020 at
>>
>> https://kernel.googlesource.com/pub/scm/utils/dash/dash/+/refs/tags/v0.5.11
>
> That isn't quite what I was implying. What I meant to say was that the
> dash _manual page_ is out-of-date w.r.t. the dash patch I linked, not
> that that version is something we could ignore.
Oh, I didn't mean it that way. I was continuing from your findings
that certain features of "local" may not have been available in
0.5.10; hence the hits from grep that showed any assignment might be
problematic with that version and we may need to downgrade our
scripts.
But as Szeder writes in a response later in the thread, assignment
on "local" may have been avaiable in versions before 0.5.11 in a
limited form (namely, it is split at $IFS unlike normal assignments,
which was the starting point of this thread), which reduces the
scope of downgrading necessary by a large margin ;-)
prev parent reply other threads:[~2022-01-27 0:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 20:11 [RFC] shell: local x=$1 may need to quote the RHS Junio C Hamano
2022-01-25 9:24 ` Konstantin Khomoutov
2022-01-25 19:00 ` Junio C Hamano
2022-01-25 20:19 ` Taylor Blau
2022-01-26 5:53 ` Junio C Hamano
2022-01-26 11:39 ` Konstantin Khomoutov
2022-01-26 21:48 ` SZEDER Gábor
2022-01-26 21:52 ` Taylor Blau
2022-01-27 0:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlez2nibl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kostix@bswap.ru \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).