From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Josh Steadmon <steadmon@google.com>,
git@vger.kernel.org, me@ttaylorr.com, jeffhost@microsoft.com
Subject: Re: [PATCH v2] test-lib: unset trace2 parent envvars
Date: Thu, 27 Jan 2022 10:29:38 -0800 [thread overview]
Message-ID: <xmqqlez12fsd.fsf@gitster.g> (raw)
In-Reply-To: <220127.86r18tdeve.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 27 Jan 2022 04:23:10 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 0f7a137c7d..faf25ba1b2 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -432,7 +432,7 @@ EDITOR=:
>> unset VISUAL EMAIL LANGUAGE $("$PERL_PATH" -e '
>> my @env = keys %ENV;
>> my $ok = join("|", qw(
>> - TRACE
>> + TRACE # Allow tracing in general, but see unsets below.
>
> I think it would be good to turn that -e into a -we, which would tell
> you why this doesn't work the way you think:
>
> Possible attempt to put comments in qw() list at -e line 14.
> Possible attempt to separate words with commas at -e line 14.
>
> I.e. you added one string "#" to the array, and a string "Allow" etc.
Having an expert who can spot these things at first glance is handy
;-). Very much appreciated.
In any case, the previous iteration has been in 'next' long enough
without causing trouble for those who use a variant based on 'next'
at $DAYJOB, I presume, so my recommendation is to just let it
graduate first, and pursue your suggestion to do more things in this
scriptlet (below, omitted) as a "further improvement" on top.
Thanks.
next prev parent reply other threads:[~2022-01-27 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 3:33 [PATCH] test-lib: unset trace2 parent envvars Josh Steadmon
2022-01-14 6:01 ` Junio C Hamano
2022-01-18 21:23 ` Josh Steadmon
2022-01-18 21:50 ` Junio C Hamano
2022-01-26 22:11 ` Josh Steadmon
2022-01-18 21:29 ` Taylor Blau
2022-01-26 22:10 ` [PATCH v2] " Josh Steadmon
2022-01-27 3:23 ` Ævar Arnfjörð Bjarmason
2022-01-27 18:29 ` Junio C Hamano [this message]
2022-02-01 21:22 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlez12fsd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=me@ttaylorr.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).