From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Matthias Aßhauer" <mha1993@live.de>,
git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: gitk regression in version 2.36.0
Date: Fri, 22 Apr 2022 23:05:46 -0700 [thread overview]
Message-ID: <xmqqlevw2v2d.fsf@gitster.g> (raw)
In-Reply-To: <xmqqpml82vkd.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 22 Apr 2022 22:54:58 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Matthias Aßhauer <mha1993@live.de> writes:
>
>> Git 2.36.0 (or more precisely 244c27242f (diff.[ch]: have diff_free()
>> call clear_pathspec(opts.pathspec), 2022-02-16)) introduced some
>> change in behaviour that causes gitks highlight feature not to work
>> correctly anymore.
>
> Nicely found.
A simple reproduction recipe without gitk is a command line
invocation like this:
$ git rev-list -10 --max-parents=1 v2.36.0 -- Documentation |
git diff-tree --stdin --stat -- Documentation
The upstream of the pipe lists 10 topmost non-merge commits, going
back from v2.36.0, that touch Documentation/ directory, and the
downstream "diff-tree" is told to show for each of these commits to
compute equivalent of "git show --stat -- Documentation", i.e. only
the Documentation directory. But "diff-tree" loses pathspec and we
will see paths outside Documentation appearing in the output.
If I substitute "git diff-tree" on the downstream of the pipe with
the version from v2.35.0, of course the correct thing happens X-<.
next prev parent reply other threads:[~2022-04-23 6:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 5:25 gitk regression in version 2.36.0 Matthias Aßhauer
2022-04-23 5:54 ` Junio C Hamano
2022-04-23 6:05 ` Junio C Hamano [this message]
2022-04-23 10:13 ` René Scharfe
2022-04-23 16:00 ` Junio C Hamano
2022-04-25 17:45 ` [PATCH] 2.36 gitk/diff-tree --stdin regression fix Junio C Hamano
2022-04-25 22:37 ` [PATCH] t4013: diff-tree --stdin with pathspec Junio C Hamano
2022-04-26 10:09 ` [PATCH] 2.36 gitk/diff-tree --stdin regression fix Phillip Wood
2022-04-26 13:45 ` Phillip Wood
2022-04-26 15:16 ` Junio C Hamano
2022-04-26 15:26 ` Junio C Hamano
2022-04-26 16:11 ` Junio C Hamano
2022-04-27 16:42 ` René Scharfe
2022-04-27 18:06 ` René Scharfe
2022-04-27 20:03 ` Junio C Hamano
2022-04-23 9:27 ` gitk regression in version 2.36.0 René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlevw2v2d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=mha1993@live.de \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).