From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 3/3] safe.directory: document and check that it's ignored in the environment
Date: Wed, 27 Apr 2022 13:42:32 -0700 [thread overview]
Message-ID: <xmqqlevql0lj.fsf@gitster.g> (raw)
In-Reply-To: <20220427170649.4949-4-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Wed, 27 Apr 2022 19:06:49 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> The description of 'safe.directory' mentions that it's respected in
> the system and global configs, and ignored in the repository config
> and on the command line, but it doesn't mention whether it's respected
> or ignored when specified via environment variables (nor does the
> commit message adding 'safe.directory' [1]).
If we had GIT_SAFE_DIRECTORIES that lists the safe directories (like
$PATH does), that would have been absolutely necessary to document
how it works, but GIT_CONFIG_* is merely an implementation detail of
how "git -c var=val" works and I am not sure if it is even a good
idea to hardcode how they happen to work like these tests. The only
thing the users should know is that GIT_CONFIG_{KEY,VALUE}_* are
used internally by the implementation and they should not muck with
it, no?
I am moderately negative about this change.
> diff --git a/t/t0033-safe-directory.sh b/t/t0033-safe-directory.sh
> index 82dac0eb93..238b25f91a 100755
> --- a/t/t0033-safe-directory.sh
> +++ b/t/t0033-safe-directory.sh
> @@ -21,6 +21,21 @@ test_expect_success 'ignoring safe.directory on the command line' '
> grep "unsafe repository" err
> '
>
> +test_expect_success 'ignoring safe.directory in the environment' '
> + test_must_fail env GIT_CONFIG_COUNT=1 \
> + GIT_CONFIG_KEY_0="safe.directory" \
> + GIT_CONFIG_VALUE_0="$(pwd)" \
> + git status 2>err &&
> + grep "unsafe repository" err
> +'
> +
> +test_expect_success 'ignoring safe.directory in GIT_CONFIG_PARAMETERS' '
> + test_must_fail env \
> + GIT_CONFIG_PARAMETERS="${SQ}safe.directory${SQ}=${SQ}$(pwd)${SQ}" \
> + git status 2>err &&
> + grep "unsafe repository" err
> +'
> +
> test_expect_success 'ignoring safe.directory in repo config' '
> (
> unset GIT_TEST_ASSUME_DIFFERENT_OWNER &&
next prev parent reply other threads:[~2022-04-27 20:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 15:32 [PATCH 0/3] Updates to the safe.directory config option Derrick Stolee via GitGitGadget
2022-04-13 15:32 ` [PATCH 1/3] t0033: add tests for safe.directory Derrick Stolee via GitGitGadget
2022-04-13 16:24 ` Junio C Hamano
2022-04-13 16:29 ` Derrick Stolee
2022-04-13 19:16 ` Ævar Arnfjörð Bjarmason
2022-04-13 19:46 ` Junio C Hamano
2022-04-13 19:52 ` Derrick Stolee
2022-04-13 15:32 ` [PATCH 2/3] setup: fix safe.directory key not being checked Matheus Valadares via GitGitGadget
2022-04-13 16:34 ` Junio C Hamano
2022-04-13 15:32 ` [PATCH 3/3] setup: opt-out of check with safe.directory=* Derrick Stolee via GitGitGadget
2022-04-13 16:40 ` Junio C Hamano
2022-04-13 16:15 ` [PATCH 0/3] Updates to the safe.directory config option Junio C Hamano
2022-04-13 16:25 ` Derrick Stolee
2022-04-13 16:44 ` Junio C Hamano
2022-04-13 20:27 ` Junio C Hamano
2022-04-13 21:25 ` Taylor Blau
2022-04-13 21:45 ` Junio C Hamano
2022-04-27 17:06 ` [PATCH 0/3] t0033-safe-directory: test improvements and a documentation clarification SZEDER Gábor
2022-04-27 17:06 ` [PATCH 1/3] t0033-safe-directory: check the error message without matching the trash dir SZEDER Gábor
2022-05-09 22:27 ` Taylor Blau
2022-05-10 6:04 ` Carlo Marcelo Arenas Belón
2022-04-27 17:06 ` [PATCH 2/3] t0033-safe-directory: check when 'safe.directory' is ignored SZEDER Gábor
2022-04-27 20:37 ` Junio C Hamano
2022-04-29 16:12 ` Derrick Stolee
2022-04-29 17:57 ` Junio C Hamano
2022-04-29 19:06 ` SZEDER Gábor
2022-04-29 19:19 ` Derrick Stolee
2022-05-10 18:33 ` SZEDER Gábor
2022-05-10 19:55 ` Taylor Blau
2022-05-10 20:06 ` Carlo Marcelo Arenas Belón
2022-05-10 20:11 ` Taylor Blau
2022-05-10 20:18 ` Eric Sunshine
2022-04-27 17:06 ` [PATCH 3/3] safe.directory: document and check that it's ignored in the environment SZEDER Gábor
2022-04-27 20:42 ` Junio C Hamano [this message]
2022-04-27 20:49 ` Junio C Hamano
2022-04-29 16:13 ` Derrick Stolee
2022-05-09 21:39 ` SZEDER Gábor
2022-05-09 21:45 ` Junio C Hamano
2022-05-10 18:48 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlevql0lj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).