From: Junio C Hamano <gitster@pobox.com>
To: "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, derrickstolee@github.com,
Phillip Wood <phillip.wood123@gmail.com>,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] read-cache: avoid misaligned reads in index v4
Date: Wed, 28 Sep 2022 10:34:32 -0700 [thread overview]
Message-ID: <xmqqleq3v1w7.fsf@gitster.g> (raw)
In-Reply-To: <pull.1366.v2.git.1664385541084.gitgitgadget@gmail.com> (Victoria Dye via GitGitGadget's message of "Wed, 28 Sep 2022 17:19:00 +0000")
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> + /*
> + * NEEDSWORK: using 'offsetof()' is cumbersome and should be replaced
> + * with something more akin to 'load_bitmap_entries_v1()'s use of
> + * 'read_be16'/'read_be32'. For consistency with the corresponding
> + * ondisk entry write function ('copy_cache_entry_to_ondisk()'), this
> + * should be done at the same time as removing references to
> + * 'ondisk_cache_entry' there.
> + */
Sounds sensible. Will replace and merge down to 'next'--- it will
most likely be part of the first batch in the next cycle.
Thanks, all.
prev parent reply other threads:[~2022-09-28 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 19:43 [PATCH] read-cache: avoid misaligned reads in index v4 Victoria Dye via GitGitGadget
2022-09-23 21:39 ` Jeff King
2022-09-23 22:04 ` Junio C Hamano
2022-09-26 15:39 ` Victoria Dye
2022-09-26 17:35 ` Jeff King
2022-09-26 19:08 ` Jeff King
2022-09-26 19:31 ` Jeff King
2022-09-26 23:02 ` Junio C Hamano
2022-09-25 8:25 ` Phillip Wood
2022-09-26 17:54 ` Junio C Hamano
2022-09-28 17:19 ` [PATCH v2] " Victoria Dye via GitGitGadget
2022-09-28 17:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqleq3v1w7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).