mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Eric Wong <>
Subject: Re: [PATCH] prune: quiet ENOENT on missing directories
Date: Tue, 22 Nov 2022 08:09:08 +0900	[thread overview]
Message-ID: <xmqqleo3vraj.fsf@gitster.g> (raw)
In-Reply-To: <xmqqpmdgv4it.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 21 Nov 2022 22:08:42 +0900")

Junio C Hamano <> writes:

>>  	prune_packed_objects(show_only ? PRUNE_PACKED_DRY_RUN : 0);
>> -	remove_temporary_files(get_object_directory());
>>  	s = mkpathdup("%s/pack", get_object_directory());
>>  	remove_temporary_files(s);
>>  	free(s);
> I actually was hinting at making the remove_temporary_files()
> recurse, so that you do not need the separate invocation in pack/
> subdirectory.
> Or make 256 calls for each of the fan-out subdirectory, in which
> case the ENOENT silencing you did would really matter and shine.

But of course, neither is any part of this topic.  They are possible
follow-on works.

Thanks and sorry for making a confusing statement that could be
mistaken as "let's do this too", which wasn't what I meant.

  reply	other threads:[~2022-11-21 23:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 20:12 [PATCH] prune: quiet ENOENT on missing directories Eric Wong
2022-11-21  6:02 ` Junio C Hamano
2022-11-21 10:44   ` Eric Wong
2022-11-21 13:08     ` Junio C Hamano
2022-11-21 23:09       ` Junio C Hamano [this message]
2022-11-22  0:09         ` [PATCH] prune: recursively prune objects directory Eric Wong
2022-11-22  1:28           ` Junio C Hamano
2022-11-22  9:59             ` Eric Wong
2022-11-22 23:16               ` Junio C Hamano
2022-11-21 11:16 ` [PATCH] prune: quiet ENOENT on missing directories Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqleo3vraj.fsf@gitster.g \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).