git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cocci: avoid "should ... be a metavariable" warnings
Date: Thu, 01 Dec 2022 07:26:18 +0900	[thread overview]
Message-ID: <xmqqlensulit.fsf@gitster.g> (raw)
In-Reply-To: <patch-1.1-31af153702e-20221130T082521Z-avarab@gmail.com> ("Ævar	Arnfjörð Bjarmason"'s message of "Wed, 30 Nov 2022 09:28:23 +0100")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Since [1] running "make coccicheck" has resulted in [2] being emitted
> to the *.log files for the "spatch" run, and in the case of "make
> coccicheck-test" we'd emit these to the user's terminal.
>
> Nothing was broken as a result, but let's refactor the relevant rules
> to eliminate the ambiguity between a possible variable and an
> identifier.
>
> 1. 0e6550a2c63 (cocci: add a index-compatibility.pending.cocci,
>    2022-11-19)
> 2. warning: line 257: should active_cache be a metavariable?
>    warning: line 260: should active_cache_changed be a metavariable?
>    warning: line 263: should active_cache_tree be a metavariable?
>    warning: line 271: should active_nr be a metavariable?
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

Thanks.  Queued.

      reply	other threads:[~2022-11-30 22:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  8:28 [PATCH] cocci: avoid "should ... be a metavariable" warnings Ævar Arnfjörð Bjarmason
2022-11-30 22:26 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlensulit.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).